Jérémie Galarneau [Thu, 26 Mar 2015 18:57:50 +0000 (14:57 -0400)]
Fix: Possible call to execvp with NULL argument on allocation failure
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 9 Feb 2015 20:07:09 +0000 (15:07 -0500)]
Fix: Save jul event filter bytecode
This fixes a regression introduced by
7ea8750c which caused the jul
event filter bytecode to be stored as NULL.
This caused the disable_event command to fail since it would fail to
lookup the JUL event (the event's filter being part of the HT's key).
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Tue, 29 Jul 2014 22:10:27 +0000 (18:10 -0400)]
Fix: out of tree build by adding missing ini.c include
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Fri, 6 Feb 2015 20:23:19 +0000 (15:23 -0500)]
Test: java-jul:missing static test files for dist and out of tree build
Reported-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 6 Feb 2015 20:09:00 +0000 (15:09 -0500)]
Tests: remove unecessary log4j test
Remove a log4j test (feature introduced in the 2.6 release) which was
erronously introduced as part of a test fix backport.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jonathan Rajotte [Fri, 30 Jan 2015 18:30:10 +0000 (13:30 -0500)]
Fix: out-of-tree build: missing xsd file for save-load test execution
This need to be backported to stable 2.6 and stable 2.5
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 26 Jan 2015 19:24:16 +0000 (14:24 -0500)]
Update version to v2.5.4
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 26 Jan 2015 19:23:41 +0000 (14:23 -0500)]
Revert "Update version to v2.5.4"
This reverts commit
06d007de14589906c8b30b9f0a1b07ea67351f24.
Jérémie Galarneau [Mon, 26 Jan 2015 19:19:01 +0000 (14:19 -0500)]
Fix: Add align.h and bug.h to src/common noinst target
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 26 Jan 2015 19:07:49 +0000 (14:07 -0500)]
Update version to v2.5.4
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 26 Jan 2015 17:14:13 +0000 (12:14 -0500)]
Tests: Run health check test_thread_ok as part of root_regression
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Fri, 23 Jan 2015 16:29:00 +0000 (11:29 -0500)]
Fix: deadlock between UST registry lock and consumer lock
Reorganize locking of ust registry and consumer socket communication.
commit
ce34fcd0 "Fix: per-uid flush and ust registry locking" attempted
to fix locking related to the UST registry, but doing so introduced a
deadlock. The actual solution is to reverse the order in which the UST
registry and the consumer lock nest: the UST registry will now to
responsible for serializing the registry content, and the consumer lock
will only protect communication with the consumer, as it should. This
deals with a TODO in the code.
The reason why this was not done from the beginning is that there was
originally an intent to make sure the ust registry lock is not held for
a long time, thus not while communicating with the consumer daemon.
However, when live has been implemented, it required communication with
the consumer daemon while the ust registry is held anyway. Therefore,
there is not much point anymore in trying to make sure this lock is not
held across the communication with consumerd in push_metadata. This
allows us to greatly simplify locking of the UST registry.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Conflicts:
src/bin/lttng-sessiond/ust-app.c
Mathieu Desnoyers [Fri, 23 Jan 2015 16:28:59 +0000 (11:28 -0500)]
Fix: uninitialized return value
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 22 Jan 2015 20:17:34 +0000 (15:17 -0500)]
Fix: build failure using disable-lttng-ust configure option
A stub for ust_app_get_size_one_more_packet_per_stream() is missing
which causes the build to fail when using the --disable-lttng-ust
configuration option.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 22 Jan 2015 04:14:52 +0000 (23:14 -0500)]
Fix: Warnings introduced by backported fixes
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 15 Jan 2015 22:24:27 +0000 (17:24 -0500)]
Fix: grab more than one packet for snapshots
There are a few issues with snapshot size: when taking a snapshot
without specifying any "max size" (should be unlimited), only a single
packet from each stream is saved. We expect all stream available content
to be saved. There is a similar issue when a max size is specified.
Also, trying to make all streams save as much data has unexpected
corner-cases: for instance, if we have this configuration:
- kernel channels: 2 subbuffers of 1MB x 8 CPUs
- per-PID UST channels: 16 subbuffers of 4kB x 8 CPUs x 100 apps
would require the user to have a very large max size, since it would try
to fit (8 + (100 * 8)) * 1MB = 808MB of sub-buffers, else it would fail.
This issue here is using the largest subbuffer size as the criterion
applied to all channels.
We fix those issues by simplifying the algorithm used to calculate how
much data to grab. Rather than calculating the size to grab from each
stream, we calculate a number of packets to grab. It fails if we cannot
grab at least one packet from each stream in the session. Then checks if
it can grab 2 packets from each stream, and so on, until there is no
more space available (based on max size). This is not a perfect
solution, but has the merit of being simple to understand, and has no
(or few) unexpected corner-cases.
Fixes #860
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Conflicts:
src/bin/lttng-sessiond/kernel.h
Mathieu Desnoyers [Thu, 15 Jan 2015 22:24:26 +0000 (17:24 -0500)]
Fix: per-uid flush and ust registry locking
Commit
c4b88406 "Fix: ust-app: per-PID app unregister vs tracing stop
races" introduces a regression for per-UID flush. It can be triggered by
the test_high_throughput_limits (root regression) test. For per-UID
tracing, we need to use the registry channel ID, not the per-application
channel ID, when asking the consumer daemon to flush.
When doing this fix, we notice that the locking rules of push_metadata()
are weird. A per-ust app session lock is protecting registry data, which
makes it impossible to call push_metadata from a ust session level (for
the entire session) in the case of per-UID tracing. Moreover, it's
unclear how holding a per-application lock can protect a registry shared
across applications in per-UID tracing. Therefore, we move all accesses
to the registry metadata_key and metadata_closed fields into the
registry lock critical section. We now only rely on RCU to ensure
existance of registry across push_metadata(), rather than relying on the
per-application session lock.
It also takes care of a documentation vs code mismatch: push_metadata()
documents that "The session lock MUST be acquired here before calling
this.", but in reality, it's the application session lock which is held
across those calls. Removing this requirement, and relying on RCU
instead, fixes this mismatch.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 20 Nov 2014 06:40:41 +0000 (07:40 +0100)]
Fix: add missing synchronization point for before app test case
Fixes a race where the application could generate all its events before
trace start.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Conflicts:
tests/utils/testapp/gen-ust-events/gen-ust-events.c
Conflicts:
tests/regression/ust/java-jul/test_java_jul
tests/regression/ust/java-log4j/test_java_log4j
Mathieu Desnoyers [Wed, 19 Nov 2014 21:40:31 +0000 (22:40 +0100)]
Fix: tests: wait output hide Terminate errors
Also: Don't hide kill errors.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Conflicts:
tests/regression/tools/mi/test_mi
Mathieu Desnoyers [Wed, 19 Nov 2014 21:40:30 +0000 (22:40 +0100)]
Fix: tests: remove killall, add missing SIGTERM handlers
Applications may change name and, thus, be missed by using
killall.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 19 Nov 2014 21:40:29 +0000 (22:40 +0100)]
Fix: high throughput test: reset bw limit on sigterm
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 19 Nov 2014 21:40:28 +0000 (22:40 +0100)]
Fix: tests: add missing wait, document missing synchro
Move all wait ${!} that target a single process to "wait", to minimize
the chances to forget some background process in the future.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Conflicts:
tests/regression/ust/java-log4j/test_java_log4j
Mathieu Desnoyers [Wed, 19 Nov 2014 21:40:27 +0000 (22:40 +0100)]
Document test anti-patterns
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 19 Nov 2014 21:40:26 +0000 (22:40 +0100)]
Fix: test flaky sleep and wait patterns
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Conflicts:
tests/regression/ust/python-logging/test_python_logging
Conflicts:
tests/regression/ust/java-jul/test_java_jul
tests/regression/ust/java-log4j/test_java_log4j
tests/utils/utils.sh
Mathieu Desnoyers [Wed, 19 Nov 2014 21:40:25 +0000 (22:40 +0100)]
Fix: tests: don't use pidof to wait for test apps
Use the bash shell "wait" to wait for all background tasks rather than
the racy "pidof". Indeed, it's possible that applications have been
forked, but not executed yet, when pidof is done, which would therefore
miss applications. Using "wait" from the shell solves this.
If we want to be really strict, we should have sessiond, consumerd, and
relayd export a file containing their own PID, and wait for this instead
of using pidof. But this will be for another fix.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Tue, 2 Dec 2014 22:21:12 +0000 (17:21 -0500)]
Fix: tests: integer too large for long type
Compiler warns on 32-bit builds.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Tue, 2 Dec 2014 22:21:11 +0000 (17:21 -0500)]
Fix: undefined operation on last_relay_viewer_session_id
Triggers compiler warning on 32-bit build.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Tue, 2 Dec 2014 22:21:10 +0000 (17:21 -0500)]
Fix: print format type mismatch
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Mon, 5 Jan 2015 21:43:08 +0000 (16:43 -0500)]
Fix: exit threads not only on goto restart
Exit threads as soon as number of FD is 0, on every loop (no need for
goto restart special case). Number of FD being 0 is a sufficient
condition for exiting the thread: it means the quit pipe has been
removed from the poll set.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Mon, 5 Jan 2015 21:43:07 +0000 (16:43 -0500)]
Fix: poll: show the correct number of fds
LTTNG_POLL_GETNB() uses wait nb_fd, which is only updated after
lttng_poll_wait returns.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Conflicts:
src/bin/lttng-sessiond/ht-cleanup.c
Conflicts:
src/bin/lttng-sessiond/jul-thread.c
Mathieu Desnoyers [Mon, 5 Jan 2015 21:43:05 +0000 (16:43 -0500)]
Fix: compat poll: add missing empty revents checks
Poll returns the entire array, including entries that have no activity.
We need to check them explicitly.
Fixes #747
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Conflicts:
src/bin/lttng-sessiond/ht-cleanup.c
Mathieu Desnoyers [Mon, 5 Jan 2015 21:43:04 +0000 (16:43 -0500)]
Fix: various compat poll/epoll issues
poll:
- fix two nb_fd off by one in "add",
- simplify array size calculation,
- add error checking,
- compress the content of array before resizing it on "del"
(out-of-bound memory access issue),
- set wait.nb_fd = 0 when no FD are present in array on wait,
- remove need_realloc flag: this can be checked internally by comparing
current->alloc_size and wait->alloc_size. Minimize the number of
duplicated state.
epoll:
- add error checking,
- simplify array size calculation (make it similar to poll),
- Set default size when poll_max_size is 0 within
compat_epoll_set_max_size(), which allow better error checking
elsewhere in epoll compat code.
Fixes #747
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Conflicts:
src/common/compat/compat-poll.c
Mathieu Desnoyers [Mon, 5 Jan 2015 02:25:09 +0000 (21:25 -0500)]
Fix: ust-app: per-PID app unregister vs tracing stop races
There are various races with UST application unregister performed
concurrently with tracing stop operation when tracing with per-pid
buffers. This randomly affects availability of data shortly after the
data pending check returns that no more data is available.
ust_app_stop_trace_all() iterates on all applications in the ust_app_ht
hash table to issue a flush on all buffers. This is needed to ensure
that the sub-buffers being written to are made available to the
consumer, for both data consumption, and for the data pending check.
Failure to execute the sub-buffer flush makes following data pending
check return that there is no data in the buffers too early, thus
resulting in an incomplete trace.
It is therefore important that an application flushes all its buffers
before it is removed from the ust_app_ht.
This is where ust_app_unregister() needs to be fixed. Note that
ust_app_unregister() executes concurrently with
ust_app_stop_trace_all(), only taking the per-session lock. The order of
flush vs hash table removal therefore matters:
We need to push the metadata before removing application from
ust_app_ht. We also need to issue a flush for all application buffers
before removing the application from ust_app_ht.
Once this is fixed, there is yet another race, this time in
ust_app_flush_trace() (now renamed ust_app_flush_session()). It is
caused by the use of ustctl_sock_flush_buffer() which asks the
application to perform the buffer flush. Unfortunately, if the
application vanishes (not reachable anymore), but its unregistration has
not yet been processed by sessiond, then ust_app_stop_trace_all() will
fail to flush the application buffers, because
ustctl_sock_flush_buffer() will fail.
This final issue is fixed by asking the consumer daemon to flush the
associated channel rather than relying on the application.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Mon, 5 Jan 2015 02:25:08 +0000 (21:25 -0500)]
Fix: data pending: allow empty streams
There are cases where a stream can be completely empty (no packet to
write) with UST: for instance, if a traced application is either
preempted for a long time, terminated, or stopped, between reserve and
commit. This will make the consumer consider that this stream has no
data ready. If this situation occurs in the first sub-buffer of a
stream, this stream will have no data at all (0 bytes).
Therefore, we need to let the data pending check consider that no data
is pending in this situation, otherwise it can make the data pending
check always return that there is data pending.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Mon, 5 Jan 2015 02:25:07 +0000 (21:25 -0500)]
Fix: ust snapshot: cleanup after error
The "break" statement on error skips the rest of the functions, thus
leaving test applications running after the end of the test, which is a
side-effect on the following tests.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 12 Dec 2014 17:50:31 +0000 (12:50 -0500)]
Update version to v2.5.3
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Julien Desfossez [Tue, 9 Dec 2014 21:38:05 +0000 (16:38 -0500)]
Fix: don't destroy the sockets if the snapshot was successful
Missing a goto to skip the error condition that was destroying the
relayd sockets even if a snapshot was successful. We want to keep them
open to reuse them for the next snapshots.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 2 Dec 2014 03:06:23 +0000 (22:06 -0500)]
Fix: Missing RCU read lock in kernel_destroy_session()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Philippe Proulx [Thu, 27 Nov 2014 22:35:32 +0000 (17:35 -0500)]
Fix: channel names are not validated
This patch ensures:
1. A channel name does not contain any '/' character, since
relative paths may be injected in the channel name
otherwise (knowing that the channel name is eventually
part of a file name)
2. A channel name does not start with a '.' character, since
trace readers (Babeltrace is one of them) could interpret
files starting with a dot as hidden files and ignore
them when opening the CTF trace
Fixes: #751
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Conflicts:
include/lttng/lttng-error.h
src/bin/lttng/commands/enable_channels.c
src/common/error.c
Jérémie Galarneau [Mon, 1 Dec 2014 21:15:49 +0000 (16:15 -0500)]
Fix: Apply consumer URI changes to all domains
See the associated bug report for a lenghty explanation of the issue
and of this fix. It fixes an issue when saving a live session's
configuration that was created by loading an .lttng file.
Fixes #866
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 28 Nov 2014 16:07:17 +0000 (11:07 -0500)]
Fix: Don't leave events enabled if they were saved in a disabled state
Events are enabled by default on creation. The session configuration
loader must make sure to disable them after creation when restoring an
event that was saved in the "disabled" state.
Reported-by: Marcel Hamer <marcel.hamer@ericsson.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 28 Nov 2014 16:58:32 +0000 (11:58 -0500)]
Test fix: LTTNG_SESSION_CONFIG_XSD_PATH expects an absolute path
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 27 Nov 2014 22:23:48 +0000 (17:23 -0500)]
Fix: Memory leak on error in alloc_argv_from_user_opts()
*** CID
1256181: Resource leak (RESOURCE_LEAK)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 26 Nov 2014 21:20:21 +0000 (16:20 -0500)]
Fix: Unreachable error logging in set_option()
*** CID
1256136: Logically dead code (DEADCODE)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:43:32 +0000 (12:43 -0500)]
Fix: test_utils_expand_path.c: out of memory error handling
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:39:13 +0000 (12:39 -0500)]
Fix: test test_ust_data.c: check OOM
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:38:21 +0000 (12:38 -0500)]
Fix: test libc-wrapper: check malloc OOM
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:37:21 +0000 (12:37 -0500)]
Fix: lttng-ctl: use zmalloc(), missing OOM check
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:36:37 +0000 (12:36 -0500)]
Fix: filter-parser.y: use zmalloc(), missing OOM check
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:36:03 +0000 (12:36 -0500)]
Fix: utils.c: check str*dup OOM
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:34:26 +0000 (12:34 -0500)]
Fix: rculfhash: use zmalloc()
Follow lttng-tools rules.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:34:01 +0000 (12:34 -0500)]
Fix: ini.c: use zmalloc()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:33:34 +0000 (12:33 -0500)]
Fix: lttng lttng.c: check strdup OOM
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:33:09 +0000 (12:33 -0500)]
Fix: lttng conf.c: use zmalloc()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:32:28 +0000 (12:32 -0500)]
Fix: lttng view.c missing strdup OOM check
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:32:13 +0000 (12:32 -0500)]
Fix: use zmalloc() in lttng view.c
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:31:52 +0000 (12:31 -0500)]
Fix: use zmalloc() in lttng list.c
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:29:43 +0000 (12:29 -0500)]
Fix: use zmalloc in lttng enable_events.c
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 23 Nov 2014 16:30:33 +0000 (11:30 -0500)]
Fix: Handle empty daemon configuration file lines
Empty daemon configuration file lines such as
my_option=
will cause set_option to be called with an arg value of length 0
which should display a warning.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:27:29 +0000 (12:27 -0500)]
Fix: missing strdup oom check in lttng create.c
Introduce tmp_path to ensure that no code path can possibly try to free
the return value of utils_get_home_dir(). Re-using alloc_path for both
static and dynamically allocated pointer is error-prone.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:25:55 +0000 (12:25 -0500)]
Fix: lttng add_context.c: use zmalloc
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:18:07 +0000 (12:18 -0500)]
Fix: add missing str*dup oom check in sessiond main.c
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:17:26 +0000 (12:17 -0500)]
Fix: add missing sessiond kernel-consumer missing str*dup oom checks
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 26 Nov 2014 17:16:19 +0000 (12:16 -0500)]
Fix: add missing strdup OOM check
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 21 Nov 2014 17:31:39 +0000 (18:31 +0100)]
Fix: Live tracing does not honor live timer after first tracefile with tracefile rotation
When we pass to the 2nd sub-file (or following sub-files) of a stream in
relayd, the live timer has no visible effect from a live reader
perspective, and then everything is flushed when we reach the following
sub-file.
This is caused by the reset of stream->total_index_received after each
tracefile rotation. It should keep on incrementing to match what is
expected by check in check_index_status():
(rstream->total_index_received <= vstream->last_sent_index)
Fixes #863
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sun, 23 Nov 2014 15:37:06 +0000 (10:37 -0500)]
Docs: Add -f/--config option to lttng-sessiond man page
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Conflicts:
src/bin/lttng-sessiond/main.c
Mathieu Desnoyers [Fri, 21 Nov 2014 17:38:37 +0000 (18:38 +0100)]
Fix: relayd: unbalanced RCU read-side lock/unlock
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Fri, 21 Nov 2014 17:42:05 +0000 (18:42 +0100)]
Fix: relayd: unbalanced RCU read lock/unlock
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Fri, 21 Nov 2014 17:47:52 +0000 (18:47 +0100)]
Fix: lttng-relayd: unhandled out of memory error
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Fri, 21 Nov 2014 17:49:08 +0000 (18:49 +0100)]
Fix: relayd viewer stream: unhandled out of memory error
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 18 Nov 2014 19:19:43 +0000 (14:19 -0500)]
Fix: Missing rcu_read_lock in cmd_list_channels()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 18 Nov 2014 19:10:14 +0000 (14:10 -0500)]
Fix: Missing rcu_read_lock in cmd_snapshot_list_outputs()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 18 Nov 2014 18:37:29 +0000 (13:37 -0500)]
Fix: Missing rcu_read_lock in ust_app_get_nb_stream()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Tue, 18 Nov 2014 16:33:23 +0000 (17:33 +0100)]
Fix: UST subbuffers silently dropped on moderate trace traffic
Well, it looks like we really screwed up on this one.
lttng-tools commit
02b3d1769d5f8a33e4109b1e681141c9295dfda6 introduced
an important regression for lttng-ust tracing in the consumer daemon:
after reading a sub-buffer, a check has been added to see whether there
are more sub-buffers available to read, and if it is the case, it
ensures the wakeup pipe will be awakened again.
The issue lies in the use of ustctl_put_next_subbuf() in this check.
This acts as if the sub-buffer has been read, when in reality it has not
been read. It therefore trashes the data contained by this sub-buffer.
This check should use ustctl_put_subbuf(), which does not move the
consumer position.
This is a severe bug, and the fix needs to be applied to stable-2.6,
stable-2.5, and stable-2.4.
Fixes #861
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 18 Nov 2014 14:35:48 +0000 (09:35 -0500)]
Fix: Missing rcu_read_lock in get_session_max_subbuf_size()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Julien Desfossez [Wed, 12 Nov 2014 23:36:17 +0000 (18:36 -0500)]
Fix: create/destroy a splice_pipe per stream
We had a per-thread splice_pipe (one for data and one for metadata), but
in case of error, we would end up filling the write side of the pipe and
never emptying it. This could lead to leaking data from one session to
the other, but also to stall the consumer trying to splice into a full
pipe.
Now we create a splice_pipe per-stream, so it is destroyed when the
session is destroyed.
Fixes: #726
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
David Goulet [Tue, 7 Oct 2014 19:05:48 +0000 (15:05 -0400)]
Fix: return EINVAL if agent registration fails
The errno value might be 0 thus not returning an error if so. It has
been seen with an unstable python agent code base which means it could
happen in the future if a third part decides to create an agent.
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Wed, 12 Nov 2014 20:19:49 +0000 (15:19 -0500)]
Note find_ust_app_context must be called with RCU read lock
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 6 Nov 2014 22:34:08 +0000 (17:34 -0500)]
Fix: check userspace perf counter name when looking up contexts
create_ust_app_channel_context() looks for a context's existance
in a channel before adding it. However, it only checks for
context types. This is valid for all context types except for
LTTNG_UST_CONTEXT_PERF_THREAD_COUNTER since multiple perf
thread counters may be enabled at the same time.
This fix ensures that the perf counter name is taken into
consideration when checking for a context's presence in a
channel.
Reported-by: Alexander Grigoriev <alexgri@tbricks.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Julien Desfossez [Tue, 11 Nov 2014 20:57:48 +0000 (15:57 -0500)]
Fix: empty indexes_ht before destroying it.
Fixes: #722
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Julien Desfossez [Tue, 11 Nov 2014 20:57:47 +0000 (15:57 -0500)]
Fix: removed useless key from relay_index
This field was never used except in debug messages (instead of using the
good value that is part of index_n).
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Thu, 13 Nov 2014 22:18:16 +0000 (17:18 -0500)]
Fix: filter bytecode and string memory leak on error
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Sat, 15 Nov 2014 04:38:36 +0000 (23:38 -0500)]
Fix: HT must not be destroyed with a rcu_read_lock held
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 13 Nov 2014 21:09:57 +0000 (16:09 -0500)]
Fix: missing rcu_read_lock in cmd_start_trace()
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Mathieu Desnoyers [Wed, 12 Nov 2014 23:18:32 +0000 (18:18 -0500)]
Fix: filter attach vs event enable race
In order to correctly handle the use-case where events are enabled
_after_ trace is started, and _after_ applications are already being
traced, the event should be created in a "disabled" state, so that it
does not trace events until its filter is attached.
This fix needs to be done both in lttng-tools and lttng-ust. In order to
keep ABI compatibility between tools and ust within a stable release
cycle, we introduce a new "disabled" within struct lttng_ust_event
padding (previously zeroed). Newer LTTng-UST checks this flag, and
fallback on the old racy behavior (enabling the event on creation) if it
is unset.
Therefore, old session daemon works with newer lttng-ust of the same
stable release, and vice-versa. However, building lttng-tools requires
an upgraded lttng-ust, which contains the communication protocol with
the new "disabled" field.
This patch should be backported to stable-2.4, stable-2.5, stable-2.6
branches.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Mon, 10 Nov 2014 22:35:26 +0000 (17:35 -0500)]
Build fix: use ret directly in error handling path
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Christian Babeux [Fri, 7 Nov 2014 23:18:43 +0000 (18:18 -0500)]
Fix: Warn the user when enabling an event in a new domain
This patch warn the user when trying to enable an event in a new domain
that was not configured prior to the tracing start.
Fixes #826
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Fri, 7 Nov 2014 23:07:07 +0000 (18:07 -0500)]
Fix: Don't report an error when listing a session with no channels
The LTTng sessiond daemon reports an error when the list_channel
command is invoked on a session which only has a metadata channel.
The error lies in assuming that a session which has an enabled
domains also has (user-visible) channels.
The metadata channel should be listed in a future fix.
Fixes #855
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Conflicts:
src/bin/lttng/commands/list.c
Christian Babeux [Fri, 7 Nov 2014 17:17:02 +0000 (12:17 -0500)]
Fix: Add missing URCU_TLS access to error_log_time
Fixes #849
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Thu, 6 Nov 2014 01:19:05 +0000 (20:19 -0500)]
Update version to v2.5.2
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 5 Nov 2014 22:34:14 +0000 (17:34 -0500)]
Update maintainer section of the man pages
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Wed, 5 Nov 2014 20:53:22 +0000 (15:53 -0500)]
Update maintainer section of README
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Jérémie Galarneau [Tue, 4 Nov 2014 22:59:29 +0000 (17:59 -0500)]
Fix: add README to documentation files
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
David Goulet [Fri, 31 Oct 2014 17:23:29 +0000 (13:23 -0400)]
Fix: UST consumer sync all available metadata
In live mode, the sync metadata function was only working on one single
metadata stream of a given session ID. However, we can have multiple
metadata stream for the same session ID thus failing to send the data in
live mode correctly for the other streams.
This fixes it by simply iterating over all metadata stream for a session
ID and syncing them all.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 20 Oct 2014 19:47:39 +0000 (15:47 -0400)]
Update version to v2.5.1
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 1 Oct 2014 18:57:36 +0000 (14:57 -0400)]
Fix: handle sysconf possible negative returned value
Fixes Coverity issue
1019947.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 1 Oct 2014 18:52:33 +0000 (14:52 -0400)]
Fix: channel deref. after NULL check in kernel consumer
Fixes Coverity issue
1040158.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 1 Oct 2014 18:49:42 +0000 (14:49 -0400)]
Fix: check for kernel session metadata during init
Fixes Coverity issue
1040159.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 1 Oct 2014 18:32:12 +0000 (14:32 -0400)]
Fix: incorrect cast in ust consumer assert
Fixes Coverity issue
1068813.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 1 Oct 2014 18:16:07 +0000 (14:16 -0400)]
Fix: bad handling of incoming data in consumer thread
This will fix Coverity issue
1019892.
The issue uncovered a more serious problem. The loop on ready FDs of the
thread was exiting at each branch thus not going on all fd. This is
problematic when the thread quit pipe is triggered and when there is
also at the same time a request for metadata from the consumer since the
metadata request could have been ignored.
This patch makes sure we go through all FDs in the loop when the thread
quit pipe or the metadata fd is triggered.
Signed-off-by: David Goulet <dgoulet@efficios.com>
This page took 0.043477 seconds and 4 git commands to generate.