Michael Jeanson [Thu, 21 Apr 2016 20:11:04 +0000 (16:11 -0400)]
Fix: writeback probe on RHEL >= 3.10.0-327.10.1
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Wed, 20 Apr 2016 21:50:05 +0000 (17:50 -0400)]
Fix: RHEL kernel 3.10.0-327.13.1 compat
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 20 Apr 2016 21:58:33 +0000 (17:58 -0400)]
Fix: ctf_user_integer should not trigger page fault
It is not used by the instrumentation currently, but fix it
nevertheless.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 20 Apr 2016 21:56:45 +0000 (17:56 -0400)]
Fix: lib_ring_buffer_copy_from_user_inatomic error handling
It should treat nonzero return value of
lib_ring_buffer_do_copy_from_user_inatomic() as errors, 0 as success.
It is currently unused by the instrumentation.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 14 Apr 2016 19:29:01 +0000 (15:29 -0400)]
Add comment describing ioctl number duplication
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 5 Apr 2016 19:25:20 +0000 (15:25 -0400)]
Fix: remove unused gfpflags.h from btrfs and compaction instrumentation
Its content is unused, and this file disappears in Linux 4.6-rc.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 5 Apr 2016 13:26:51 +0000 (09:26 -0400)]
Fix: Remove dead code from filter interpreter
Detected by Coverity:
** CID
1353794: Control flow issues (DEADCODE)
/lttng-filter-interpreter.c: 123 in stack_strcmp()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 5 Apr 2016 12:36:44 +0000 (08:36 -0400)]
Fix: x86 kvm mmutrace instrumentation for kernel < 3.6
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 5 Apr 2016 12:09:13 +0000 (08:09 -0400)]
Fix: mm_vmscan instrumentation: remove unused gfpflags.h include
This header disappears in kernel 4.6, but we don't actually use it, so
remove its include.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 5 Apr 2016 12:05:42 +0000 (08:05 -0400)]
Fix: use of uninitialized ret value in lttng_abi_create_event
Fixes the following compiler warning:
/home/jenkins/workspace/lttng-modules_VERSION_param-build/arch/x86-32/src/lttng-modules/lttng-abi.c: In function ‘lttng_abi_create_event’:
/home/jenkins/workspace/lttng-modules_VERSION_param-build/arch/x86-32/src/lttng-modules/lttng-abi.c:987:16: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
int event_fd, ret;
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 4 Apr 2016 19:57:24 +0000 (15:57 -0400)]
Fix: kmem instrumentation: remove unused gfpflags.h include
This header disappears in kernel 4.6, but we don't actually use it, so
remove its include.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 4 Apr 2016 19:55:28 +0000 (15:55 -0400)]
Fix: 4.6 kernel: use in_compat_syscall
in_compat_sycall appears in kernel 4.6. Use it instead of
is_compat_task(), but use is_compat_task() as fallback.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 4 Apr 2016 18:39:16 +0000 (14:39 -0400)]
Fix: use BUG_ON instead of accessing array subscript above array bounds
Building lttng-modules lttng-filter-interpreter.c on a 4.6-rc kernel
triggers the following gcc warning:
In file included from /home/compudj/git/lttng-modules/lttng-filter-interpreter.c:25:0:
/home/compudj/git/lttng-modules/lttng-filter-interpreter.c: In function ‘lttng_filter_interpret_bytecode’:
/home/compudj/git/lttng-modules/lttng-filter.h:144:14: warning: array subscript is above array bounds [-Warray-bounds]
&(stack)->e[top]; \
^
/home/compudj/git/lttng-modules/lttng-filter-interpreter.c:714:4: note: in expansion of macro ‘estack_ax’
estack_ax(stack, top)->u.s.str = insn->data;
^
/home/compudj/git/lttng-modules/lttng-filter.h:144:14: warning: array subscript is above array bounds [-Warray-bounds]
&(stack)->e[top]; \
^
/home/compudj/git/lttng-modules/lttng-filter-interpreter.c:715:4: note: in expansion of macro ‘estack_ax’
estack_ax(stack, top)->u.s.seq_len = UINT_MAX;
This is because the bound checking is performed in a prior validation
phase (which the compiler does not know about), and we only
WARN_ON_ONCE() if the interpreter sees values that don't fit in array
range.
Use BUG_ON() in the interpreter instead, which ensures we never, ever
reach the out-of-bound condition from a compiler perspective.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Tue, 29 Mar 2016 23:32:19 +0000 (19:32 -0400)]
Fix: Add granularity to RHEL kernel version checks
Our RHEL kernel version macros were based on the major and minor version
of the distribution version like "7.2" instead of the full kernel version
like "327.4.4". This prevented us from adding compatibility changes with
sufficient granularity.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 18 Mar 2016 22:21:44 +0000 (18:21 -0400)]
Version 2.8.0-rc1
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 18 Mar 2016 21:32:21 +0000 (17:32 -0400)]
Bump minor tracer ABI version
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 16 Mar 2016 15:23:43 +0000 (11:23 -0400)]
Fix: build against out-of-tree kernel build
Fix following system header include modifications.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Mar 2016 16:24:12 +0000 (12:24 -0400)]
probes/Kbuild: remove upper level header path
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Mar 2016 16:12:46 +0000 (12:12 -0400)]
Move leftover relative include paths to system paths
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Mar 2016 16:02:27 +0000 (12:02 -0400)]
syscall instrumentation: use system headers
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Mar 2016 15:56:24 +0000 (11:56 -0400)]
tracepoint event instrumentation: use system headers
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Mar 2016 15:45:00 +0000 (11:45 -0400)]
Use system include path in wrappers
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Mar 2016 15:41:09 +0000 (11:41 -0400)]
libs: use system include paths
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Mar 2016 15:35:47 +0000 (11:35 -0400)]
Use system header paths in core implementation files
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Mar 2016 15:27:52 +0000 (11:27 -0400)]
Use system include paths in root directory headers
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Mar 2016 15:16:43 +0000 (11:16 -0400)]
Use system include paths in probes
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Mar 2016 15:03:08 +0000 (11:03 -0400)]
Update gitignore
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Mar 2016 15:02:33 +0000 (11:02 -0400)]
Use system include paths in lttng-types.h
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Mar 2016 15:01:32 +0000 (11:01 -0400)]
Use system include paths in lttng-tracepoint-event-impl.h
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Mar 2016 14:59:47 +0000 (10:59 -0400)]
Use system include path in probes/define_trace.h
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Mar 2016 14:58:45 +0000 (10:58 -0400)]
Use system include paths in probes/lttng-tracepoint-event-impl.h
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Mar 2016 14:57:39 +0000 (10:57 -0400)]
Rename probes/lttng-events.h to probes/lttng-tracepoint-event-impl.h
Ensure we don't have a duplicated header file name in the tree.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Mar 2016 14:45:44 +0000 (10:45 -0400)]
Add makefile directory to include path
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 10 Mar 2016 01:21:42 +0000 (20:21 -0500)]
Fix: event ctx get size should be after chan ctx
Match the record functions, and the CTF spec. This has no impact
currently because event contexts are not implemented.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 8 Mar 2016 16:34:01 +0000 (11:34 -0500)]
Fix: filter interpreter with userspace strings
The filter interpreter is populating the "str" register field, but the
string comparison functions expect to use the "user_str" register field
whenever it deals with a userspace string ("user" flag set to 1).
Since we are using __copy_from_user_inatomic(), this is typically
bailing out on anything that requires to read the string (except the '*'
wildcard).
Fixes #943
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 8 Mar 2016 15:49:52 +0000 (10:49 -0500)]
Fix: rename kvm x86 TRACE_SYSTEM to avoid name clash
The lttng-probe-kvm and lttng-probe-kvm-x86 have the same TRACE_SYSTEM
string. Because of that, both modules can't be loaded at the same time.
The second module fails to load silently. Rename the TRACE_SYSTEM of
lttng-probe-kvm-x86 to avoid the clash.
We need to use the LTTNG_TRACEPOINT_EVENT_MAP to perform this
namespacing while still hooking onto the kernel tracepoints.
Fixes #895
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 8 Mar 2016 15:30:33 +0000 (10:30 -0500)]
Fix: format address fields as hexadecimal
Fixes #947
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 7 Mar 2016 23:24:25 +0000 (18:24 -0500)]
PowerPC-64 ABIv1: add build error if KALLSYMS_ALL is missing
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 25 Feb 2016 15:46:54 +0000 (10:46 -0500)]
Fix: system call instrumentation overrides
* All architectures
- For mmap, print the "ret" value as an hexadecimal integer (rather than
base 10), which better suits a pointer.
- Add missing "clone" override define, which ensures the clone
system call override is used rather than leaving it as an
"unknown" system call.
* ARM32
- Add missing output return values to arm_fadvise64_64,
sync_file_range2.
- Handle the 64-bit parameters of both arm_fadvise64_64 and
sync_file_range2 correctly on arm32, on big and little endian builds.
- Move the mmap2 system call instrumentation from "pointers" to
"integers" override header, and add the missing return value
(sc_exit).
* PPC32
- Add sync_file_range2 system call instrumentation. Handle the
64-bit parameters on big and little endian builds.
- Move the mmap2 system call instrumentation from "pointers" to
"integers" override header, and add the missing return value
(sc_exit).
* PPC64 compat
- Include compatibility (ppc32) header in ppc64 build to trace compat
system calls on PPC64 big endian.
* x86-32
- Add mmap2 system call instrumentation override.
- Add sync_file_range instrumentation override, correctly combining
the low/high parts of offset and nbytes into 64-bit fields.
Tested-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 4 Mar 2016 01:00:50 +0000 (20:00 -0500)]
Fix: page_alloc wrapper incorrect parenthesis
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 22 Feb 2016 21:57:37 +0000 (16:57 -0500)]
Fix: system call tracing for arm-64 compat !CONFIG_UID16
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 20 Feb 2016 00:00:20 +0000 (19:00 -0500)]
Fix: add struct user_msghdr forward declaration for older kernels
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Fri, 12 Feb 2016 20:26:23 +0000 (15:26 -0500)]
Cleanup: Remove unused lttng-types module
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 12 Feb 2016 20:11:04 +0000 (15:11 -0500)]
Fix: add missing versions and init call for page_alloc wrapper
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Wed, 10 Feb 2016 16:08:14 +0000 (11:08 -0500)]
Fix: Define lttng-tracer metadata only once
Fixes sysfs trying to create the lttng-tracer module version node
multiple times.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Tue, 9 Feb 2016 20:16:56 +0000 (15:16 -0500)]
Fix: Add CONFIG_LTTNG to modules_install target
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Mon, 8 Feb 2016 21:33:17 +0000 (16:33 -0500)]
Fix: Use kbuild env instead of a custom var KERNELDIR
We currently use the custom variables KERNELDIR and LTTNG_KERNELDIR
to pass the kernel source tree directory to helper scripts. We should
instead use the built-in Kbuild variable CURDIR which is available in
all sub makefiles and always points to the kernel sources.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 8 Feb 2016 21:58:32 +0000 (16:58 -0500)]
Update clock offset comment
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 8 Feb 2016 21:52:05 +0000 (16:52 -0500)]
clock offset: print negative value in metadata
In the upcoming 2.8, we can print the negative value of clock offset in
the metadata, and expect users to update their viewers to correct any
bug that could prevent them from handling those negative values.
This happens only in cases where the system sets CLOCK_REALTIME to 0
after boot, thus leading to a negative clock offset value between
realtime and monotonic clocks.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 8 Feb 2016 21:38:46 +0000 (16:38 -0500)]
Fix: handle negative clock offset
In the unlikely situation where a system sets its hardware clock
(CLOCK_REALTIME) to 0 (Epoch) after boot, the difference
monotonic - realtime
becomes negative.
Fixup this situation by returning a 0 offset in this case.
This ensures that trace viewer implementations (e.g. babeltrace) which
currently cannot handle the negative offset (known bug) still work with
the generated traces.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Fri, 5 Feb 2016 22:53:07 +0000 (17:53 -0500)]
Fix: sched instrumentation for 4.1-rt11
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Fri, 5 Feb 2016 22:53:06 +0000 (17:53 -0500)]
Add RT patch version macros
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 4 Feb 2016 00:17:35 +0000 (19:17 -0500)]
Expect filter context identifiers starting with $ctx.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 3 Feb 2016 14:29:15 +0000 (09:29 -0500)]
ARM64: wire up compat system calls
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Jan Willeke [Wed, 3 Feb 2016 13:04:12 +0000 (14:04 +0100)]
Add support for arm64 syscalls
[ Edit by Mathieu Desnoyers: rename "x86_64" strings to "arm64" in
comments. ]
Signed-off-by: Jan Willeke <jan.willeke@harman.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Fri, 29 Jan 2016 22:46:03 +0000 (17:46 -0500)]
Fix: Ubuntu kernel range for block_rq_complete
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Fri, 29 Jan 2016 22:46:02 +0000 (17:46 -0500)]
Fix: Ubuntu kernel range for mm_page_alloc_extfrag
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 25 Jan 2016 19:23:43 +0000 (14:23 -0500)]
Fix: update vmscan instrumentation for kernel 4.5
The following tracepoint changes made their way into Linux 4.5-rc1:
commit
3aa2385111168187f24a6db04697c6fab0fab9b4
Author: yalin wang <yalin.wang2010@gmail.com>
Date: Thu Jan 14 15:18:30 2016 -0800
mm/vmscan.c: change trace_mm_vmscan_writepage() proto type
and
commit
ba5e9579433aefcdccdec207601e124d3bdf2a71
Author: yalin wang <yalin.wang2010@gmail.com>
Date: Thu Jan 14 15:18:48 2016 -0800
mm: change mm_vmscan_lru_shrink_inactive() proto types
Update the lttng-modules instrumentation to match those changes.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 19 Jan 2016 14:51:55 +0000 (09:51 -0500)]
Fix: check reference counts for overflow
Linux kernel CVE-2016-0728 is a use-after-free based on overflow of the
reference counting mechanism.
Implement a kref wrapper in lttng that validates overflows, and use it
instead of kref_get(). Also check explicitly for overflows on file
fcount counters.
This should not be an issue in practice in lttng-modules because the ABI
is only exposed to root, but let's err on the safe side.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Thu, 14 Jan 2016 19:35:47 +0000 (14:35 -0500)]
Fix: RHEL 7.2 scsi instrumentation
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Thu, 14 Jan 2016 19:35:46 +0000 (14:35 -0500)]
Fix: RHEL 7.2 kvm instrumentation
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 18 Dec 2015 21:44:05 +0000 (16:44 -0500)]
Kconfig: describe both module and in-kernel compilation options
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Fri, 11 Dec 2015 22:06:41 +0000 (17:06 -0500)]
Add comments and indentation to Makefile
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Fri, 11 Dec 2015 21:33:09 +0000 (16:33 -0500)]
Add support for built-in kernel build
To build the LTTng modules as builtins in a kernel image, simply run
the "built-in.sh" script with the path to you kernel source directory
as an argument. Then configure your kernel build and add the "CONFIG_LTTNG"
option. Build as usual and voila!
This is an early implementation with a single configuration option that
enables or disables everything, We could add fine grained config options
for each modules or group of modules.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Fri, 11 Dec 2015 21:26:22 +0000 (16:26 -0500)]
Rename sub makefiles to Kbuild
This follows kbuild's convention and makes it clear that the make
command has to be run from the base directory.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Fri, 11 Dec 2015 21:25:00 +0000 (16:25 -0500)]
Cleanup sub makefiles
Remove unsused directives which are part of the main makefile, add
indentation and comments to conditions.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Fri, 11 Dec 2015 20:31:25 +0000 (15:31 -0500)]
Make goals configurable with CONFIG_LTTNG
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Thu, 10 Dec 2015 16:26:29 +0000 (11:26 -0500)]
Fix: Use generic raw_irqs_disabled_flags
instead of arch_irqs_disabled_flags, this fixes the build for kernel < 2.6.37
See linux commit
df9ee29270c11dba7d0fe0b83ce47a4d8e8d2101 for more details.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Antoine Busque [Fri, 4 Dec 2015 20:16:59 +0000 (15:16 -0500)]
Fix: Use MAX_RT_PRIO offset in sched_wakeup_template
All other sched_* events with prio fields offset the task_struct's
prio value by subtracting MAX_RT_PRIO. This way the value corresponds
to that given by the kernel's task_prio function, and thus with the
prio context field.
This adds the same offset to sched_wakeup, sched_wakeup_new, and
sched_waking, via the sched_wakeup_template event class. This way
their value is comparable to other sched_* events, and the prio
context.
Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 27 Nov 2015 19:57:44 +0000 (14:57 -0500)]
Fix: update sched instrumentation for kernel 4.4.0
Due to upstream Linux kernel commit:
commit
c73464b1c8434ad4cbfd5369c3e724f3e8ffe5a4
Author: Peter Zijlstra <peterz@infradead.org>
Date: Mon Sep 28 18:06:56 2015 +0200
sched/core: Fix trace_sched_switch()
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Wed, 25 Nov 2015 17:54:03 +0000 (12:54 -0500)]
Bump version number for development branch
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 17 Nov 2015 19:29:08 +0000 (14:29 -0500)]
Fix: interruptible context: reversed logic
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Thu, 12 Nov 2015 20:49:24 +0000 (15:49 -0500)]
Contexts for RT debugging
Add the interruptible, preemptible, need_resched and migratable
contexts.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 10 Nov 2015 18:01:50 +0000 (13:01 -0500)]
Fix: instrumentation: v4lv2 missing include
Starting at least with 4.3 kernel, we need to specifically include
media/videobuf2-core.h.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sun, 25 Oct 2015 15:23:31 +0000 (11:23 -0400)]
Fix: header size larger than 256 bytes
When adding large context (e.g. callstack), headers larger than 256
bytes cause discrepancy between calculated size and size written into
the trace buffers. This generates a corrupted trace and triggers a
warning in ring buffer backend, which triggers a safety net disabling
tracing for the current channel.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 23 Oct 2015 23:29:34 +0000 (19:29 -0400)]
Instrument x86 page faults
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 23 Oct 2015 22:44:39 +0000 (18:44 -0400)]
Fix: irq_vectors TRACE_SYSTEM name
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 23 Oct 2015 21:09:30 +0000 (17:09 -0400)]
Instrument x86_irq_vectors
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 23 Oct 2015 21:17:43 +0000 (17:17 -0400)]
Fix: tracepoint listing misses last loaded probe
The seqfile iteration listing tracepoints operates on the probe list
directly, without going through the lttng_get_probe_list_head()
accessor which ensures that the lazy list of probes is moved to the
actual list of probes.
This causes an issue when loading a probe and then listing the
tracepoints when no tracing sessions are active: the last probe loaded
is missing from the listing.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 9 Oct 2015 16:24:23 +0000 (12:24 -0400)]
Fix: lttng trace-clock needs to disable preemption
We use a per-cpu data structure, and some contexts (e.g. buffer create)
call this function with preemption enabled. This is the case also for
buffer flush operation.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 9 Oct 2015 14:02:37 +0000 (10:02 -0400)]
Tracepoint event: add "TP_code_post()"
Useful for probes that need to perform teardown after serialization,
e.g. allocate temporary memory in TP_code_pre() and free it in
TP_code_post(). Be careful to only use memory allocation from contexts
allowing it.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Thu, 8 Oct 2015 20:02:06 +0000 (16:02 -0400)]
Implement array and sequence bitfields
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 3 Oct 2015 15:57:39 +0000 (11:57 -0400)]
Fix: kmem: add mm.h include
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sat, 3 Oct 2015 15:34:37 +0000 (11:34 -0400)]
Add page frame number (pfn) to kmem page events
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 28 Apr 2015 14:55:37 +0000 (10:55 -0400)]
Use pfn rather than struct page in ring buffer array
First step to support permanent memory (e.g. pmem) which does not have
struct page.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Sun, 12 Oct 2014 11:47:15 +0000 (13:47 +0200)]
Implement clock plugin support
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Julien Desfossez [Fri, 7 Aug 2015 21:07:28 +0000 (17:07 -0400)]
Command to regenerate the metadata of a session
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Tue, 15 Sep 2015 19:46:01 +0000 (15:46 -0400)]
Fix: writeback instrumentation update for 4.3 Linux kernel
Linux upstream commit:
commit
5634cc2aa9aebc77bc862992e7805469dcf83dac
Author: Tejun Heo <tj@kernel.org>
Date: Tue Aug 18 14:54:56 2015 -0700
writeback: update writeback tracepoints to report cgroup
Updated the tracepoint signatures for writeback probes. Follow this
change. Don't add extra data (cgroup information) yet.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Mon, 14 Sep 2015 16:12:43 +0000 (12:12 -0400)]
Fix: update sched wakeup instrumentation for 4.3 kernel
Change introduced in upstream Linux:
commit
fbd705a0c6184580d0e2fbcbd47a37b6e5822511
Author: Peter Zijlstra <peterz@infradead.org>
Date: Tue Jun 9 11:13:36 2015 +0200
sched: Introduce the 'trace_sched_waking' tracepoint
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Fri, 11 Sep 2015 20:06:25 +0000 (16:06 -0400)]
Fix: lttng-test build failure for kernels < 3.0
Fixes an undefined reference to kstrtouint_from_user.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Lars Persson [Tue, 8 Sep 2015 13:31:46 +0000 (15:31 +0200)]
Use 3.18 syscall instrumentation for MIPS32
Signed-off-by: Lars Persson <larper@axis.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Lars Persson [Tue, 8 Sep 2015 13:31:45 +0000 (15:31 +0200)]
Update the MIPS32 syscall instrumentation to 3.18
Signed-off-by: Lars Persson <larper@axis.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Lars Persson [Tue, 8 Sep 2015 13:20:15 +0000 (15:20 +0200)]
Fix: Move pipe override to the arch specific pointers_override.h
The MIPS architecture has a non-standard calling convention for pipe()
and cannot use the provided override for the pipe event.
Signed-off-by: Lars Persson <larper@axis.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 4 Sep 2015 20:36:22 +0000 (16:36 -0400)]
Implement lttng test module
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 4 Sep 2015 05:29:49 +0000 (01:29 -0400)]
Cleanup: remove logically dead code
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 4 Sep 2015 05:16:52 +0000 (01:16 -0400)]
Fix: filter validator use after free
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 4 Sep 2015 05:12:53 +0000 (01:12 -0400)]
Fix: use after free in channel release
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Wed, 2 Sep 2015 02:27:35 +0000 (22:27 -0400)]
Fix: non-enabler events should be disabled by default
The session daemon expects that all events (enablers and events) are
disabled when created, so we can attach a filter before enabling them.
Also fix the kretprobe to ensure we can enable/disable both the entry
and return probe (--function instrumentation).
Fixes: #926
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Michael Jeanson [Mon, 31 Aug 2015 13:57:18 +0000 (09:57 -0400)]
Fix: build failure on 2.6.36
Fixes build failure on the 2.6.36 kernel branch which misses the
vzalloc() function.
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mathieu Desnoyers [Fri, 21 Aug 2015 16:28:44 +0000 (09:28 -0700)]
Cleanup: split bdi_dirty_ratelimit with ifdef into separate macros
Makes the code easier to maintain in the long run.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
This page took 0.042641 seconds and 4 git commands to generate.