Cleanup and streamline kernel and ust teardown session

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix null pointer dereference when destroying a UST session with no channels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Rename "comm" context into "procname"

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix nb_domain signedness in list command

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix multi-channel listing

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

edit printout in lttng list "all" channels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Report errors in write_config

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Allocate session UID with count increment

Otherwise, the UST session UID gets assigned only when the first UST
channel is created for a session, causing IDs to be used for many
sessions (the count of the number of sessions allocated so far) if the
session creation / channel creation is not performed in a usual
sequence.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix reversed enabled/disabled, active/inactive printout

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement 32/64 bit consumer support

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix consumer pid mutex double-unlock

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Introduce build/env/argument override for 32-bit compat consumer

Also remove unnecessary use of strdup on optarg.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add configure LTTNG_TOOLS_COMPAT_BIN_PREFIX env var support

Defines CONFIG_COMPAT_BIN_PREFIX in the build.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Simply close socket when application registration is refused

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update warning msg

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix warning about hash type

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Detect 32-bit compat applications + 32-bit warning fixes

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement UST destroy session

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement UST stop command

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Ensure sockets are kept open across all their hash table life-span

Otherwise causes races where re-use of a socket is being incorrectly
removed.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Support older autotools versions lack of AM_SILENT_RULES

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add creation time to UST app path to ensure uniqueness

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

ust-app: fix bogus double-use of iterator

"yo dawg, I'm using my iterator in my iterator".

;-)

Fixes pretty much all of N event/N channel/N session UST problems.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

UST consumer: fix read on hangup, and UST get subbuf error handling

This fixes multiple consecutive runs of the "demo" program, where
sometimes one channel would not be saved.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix multi-session UST handling combined with shm fd teardown

shm fd is used as unique identifier for the channel when passing the
stream fds to the consumer. However, closing the fd reuses the same
identifier for the next round, thus getting the same consumer
channel/streams as the previous one. This causes multi-session tracing
to only work for the first session, not the following ones.

So instead of doing a channel lookup on add channel and a stream lookup
upon add stream, we "steal" the identifier. We still lookup the channel
identifier upon stream add though: this means the sessiond needs to keep
the channel shm fd open until it has finished sending all stream fds to
the consumer. For kernel consumer, the update operation still does a
stream id lookup.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

lttng-sessiond: keep enabled/active state for sessions, cleanup enabled state for events/channels

allows

lttng list
Available tracing sessions:
  1) test1 (/root/lttng-traces/test1-20111115-191312) [inactive]
  2) test2 (/root/lttng-traces/test2-20111115-191310) [active]

and

root@thinkos:~# lttng list test2
Tracing session test2: [active]
    Trace path: /root/lttng-traces/test2-20111115-191502

When events/channels/sessions enabled state is set to -1, show an empty
string instead of the meaningless "[enabled: -1]".

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

rculfhash: add missing braces around iteration macros pos parameter

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

lttng-sessiond: keep track of UST consumer fd for all UST sessions.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Change malloc to zmalloc in lttng-sessiond code

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Cleanup and add comments to ust_app.c

Mostly cleanup the code by moving static functions up and creating
wrapper function around the ustctl_* API calls.

Also, replace all hashtable iteration structure by cds each entry
macros.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Fix enabled state when listing UST events

NOTE: When listing all UST events from all registered apps, the enabled
state is set to -1 meaning that there is no enable/disable state
semantic at this point.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Multiple fixes when cleaning app and UST sessions

Also adds event's attributes to the ust_app_event data structure.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Add important DEBUG statement

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Cleanup trace ust destroy functions

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Merge branch 'master' of git://git.lttng.org/lttng-tools

Add cleanup function for UST app

Also, those functions uses the new ustctl_release_object function from
the UST API.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Change malloc to zmalloc on UST metadata creation

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Add hashtable destroy

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Fix possible NULL UST session on start trace

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Fix indentation

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

sessiond: don't link on lttng-ust-comm anymore

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix incorrect POPT_ARG_STRING usage

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

lttng enable-events: fix argument parsing

We should only specify one of arg expected is a string/opt string _or_
that the callback needs to read it, but not both.

Causes some arguments to be skipped with some libpopt versions.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix debug message channel vs session name mixup

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove leftover debug message

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

add_ustctx_all_channels: Move rcu_read_unlock in error label

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

ust_app_find_by_pid: move rcu_read_unlock to error label

Less error-prone than read unlock within the code, as proven by commit
1e3a10e37a519046fd49c77f2fa23807b132f330.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

sessiond find_app_by_sock: remove double-rcu-unlock in from error paths

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

sessiond trace-ust: fix memleak on error paths

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

lttng UI: read opt_cmd_name opt arg for each command

Ensure all commands are layed out in the same way too.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

LTTng sessiond: fix ust app error handling

Fix incorrect error handling of ust_app_add_channel_all and
ust_app_add_event_all commands. Make ust_app_start_trace take RCU
read-side lock, because this API is exposed outside of ust-app.c.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix link to git repository

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Fix NULL dereference in liblttngctl

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Merge branch 'master' of git://git.lttng.org/lttng-tools

Add tracepoint listing for UST

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Fix not NULL pointer on size 0

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Update from upstream for ht macros

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

UST support: send commands to app before register done

Required for handling of short-lived applications.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix ust consumer channel memory non-zeroed allocation

The cpu count was expecting memory to be zeroed on allocation. Caused
stream open errors and zero-sized metadata files (and unability to open
channel files).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update ust-abi/ust-ctl header copies

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup ust-app.c and make it more modular

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Fix possible NULL pointer dereference

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Fix wrong pathname creation for UST metadata

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Fix directory creation of UST traces

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Fix useless context hashtable size and segfault on destroy

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Add auto start UST trace support

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

UST consumer: perform buffer flush on hang up

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix wrong returned valu on UST start trace

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Fix build system for urcu wfqueue

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Auto creation of chan/event on apps registration

On UST apps registration, all channel(s) and event(s) from the UST
global domain are created on the apps.

Adds a new check for urcu wait-free queue in configure.ac

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Add missing function references with no UST support

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Fix incorrect parenthesis for poll test in consumer

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

UST consumer: implement missing ust-specific callbacks + fixes.

Also fix consumer handling of poll fd: a mask should be used.
Also fix UST stream output passed to the consumer (the fix is a hack
currently, left a FIXME).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add missing rcu_read_unlock on error paths

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix order of streams

Use a list instead of hash table to send streams in correct order.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

UST consumer interaction fix: send all channel streams

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

LTTng-UST support: --disable-lttng-ust build option

From now on, configure fails if lttng-ust is not found.
--disable-lttng-ust must be explicitely specified to build without UST
support.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

ust consumer: flag shm/wait fd as copy

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

ust consumer: fix double close

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

consumer handling fix: send metadata channel shm size

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix UST consumer FD send: channels only send one FD

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix debug message in send consumer fd.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove *bad* debug printf

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Change linking libs using new UST names

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Fix configure.ac using new UST headers location

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Change UST header location and update in tree headers

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Support urcu 0.6.6 with the likely/unlikely API change

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Rename ltt-sessiond to lttng-sessiond

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Fix UST renaming and update ust headers

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Update README and TODO

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Fix build system with libustcomm removed

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Remove unused and empty lib

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

ltt-sessiond: use short options for modprobe in order to support Busybox

Many embedded systems are based on Busybox, and therefore use the
Busybox implementation of modprobe. This implementation does not
support long options such as --remove and --quiet, only short options
such as -r and -q are supported.

This patches changes ltt-sessiond to use the short options, which are
more widely available, and allows lttng to work easily on a
Busybox-based system.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Preliminary work for full UST support

Add hashtable support for all UST data structure. At this point, enable
channel and event works with the global UST domain. The interaction with
the ust consumer has problems for now thus not working at this stage.

NOTICE: This commit does NOT work with the user space tracer yet. Please
refer to next commit for working version.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Update RCU hashtable from upstream urcu

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Import hashtable files from URCU upstream git

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Basic hashtable support for UST

Signed-off-by: David Goulet <david.goulet@polymtl.ca>

Update documentation following babeltrace UI change

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

UST support: add UST control commands

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix kconsumerd number of fd expected

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>