From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Fri, 2 Sep 2022 20:18:43 +0000 (-0400)
Subject: __lttng_counter_add: skip effect-less code when global_sum_step=0
X-Git-Url: http://git.lttng.org./?a=commitdiff_plain;h=d712373637fc2144cde7212cf7252dbb9c6b9c3e;p=lttng-ust.git

__lttng_counter_add: skip effect-less code when global_sum_step=0

Skip effect-less code in the common case where global_sum_step=0.
This saves about 1.5ns on x86-64.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I0dacb9f189c0d47dd608dbef6f4aba969a6b0a4a
---

diff --git a/src/common/counter/counter-api.h b/src/common/counter/counter-api.h
index 7b341d97..39f2d5d3 100644
--- a/src/common/counter/counter-api.h
+++ b/src/common/counter/counter-api.h
@@ -66,11 +66,13 @@ static inline int __lttng_counter_add(const struct lib_counter_config *config,
 				move_sum = 0;
 				old = res;
 				n = (int8_t) ((uint8_t) old + (uint8_t) v);
-				if (caa_unlikely(n > (int8_t) global_sum_step))
-					move_sum = (int8_t) global_sum_step / 2;
-				else if (caa_unlikely(n < -(int8_t) global_sum_step))
-					move_sum = -((int8_t) global_sum_step / 2);
-				n -= move_sum;
+				if (caa_unlikely(global_sum_step)) {
+					if (caa_unlikely(n > (int8_t) global_sum_step))
+						move_sum = (int8_t) global_sum_step / 2;
+					else if (caa_unlikely(n < -(int8_t) global_sum_step))
+						move_sum = -((int8_t) global_sum_step / 2);
+					n -= move_sum;
+				}
 				res = uatomic_cmpxchg(int_p, old, n);
 			} while (old != res);
 			break;
@@ -107,11 +109,13 @@ static inline int __lttng_counter_add(const struct lib_counter_config *config,
 				move_sum = 0;
 				old = res;
 				n = (int16_t) ((uint16_t) old + (uint16_t) v);
-				if (caa_unlikely(n > (int16_t) global_sum_step))
-					move_sum = (int16_t) global_sum_step / 2;
-				else if (caa_unlikely(n < -(int16_t) global_sum_step))
-					move_sum = -((int16_t) global_sum_step / 2);
-				n -= move_sum;
+				if (caa_unlikely(global_sum_step)) {
+					if (caa_unlikely(n > (int16_t) global_sum_step))
+						move_sum = (int16_t) global_sum_step / 2;
+					else if (caa_unlikely(n < -(int16_t) global_sum_step))
+						move_sum = -((int16_t) global_sum_step / 2);
+					n -= move_sum;
+				}
 				res = uatomic_cmpxchg(int_p, old, n);
 			} while (old != res);
 			break;
@@ -148,11 +152,13 @@ static inline int __lttng_counter_add(const struct lib_counter_config *config,
 				move_sum = 0;
 				old = res;
 				n = (int32_t) ((uint32_t) old + (uint32_t) v);
-				if (caa_unlikely(n > (int32_t) global_sum_step))
-					move_sum = (int32_t) global_sum_step / 2;
-				else if (caa_unlikely(n < -(int32_t) global_sum_step))
-					move_sum = -((int32_t) global_sum_step / 2);
-				n -= move_sum;
+				if (caa_unlikely(global_sum_step)) {
+					if (caa_unlikely(n > (int32_t) global_sum_step))
+						move_sum = (int32_t) global_sum_step / 2;
+					else if (caa_unlikely(n < -(int32_t) global_sum_step))
+						move_sum = -((int32_t) global_sum_step / 2);
+					n -= move_sum;
+				}
 				res = uatomic_cmpxchg(int_p, old, n);
 			} while (old != res);
 			break;
@@ -190,11 +196,13 @@ static inline int __lttng_counter_add(const struct lib_counter_config *config,
 				move_sum = 0;
 				old = res;
 				n = (int64_t) ((uint64_t) old + (uint64_t) v);
-				if (caa_unlikely(n > (int64_t) global_sum_step))
-					move_sum = (int64_t) global_sum_step / 2;
-				else if (caa_unlikely(n < -(int64_t) global_sum_step))
-					move_sum = -((int64_t) global_sum_step / 2);
-				n -= move_sum;
+				if (caa_unlikely(global_sum_step)) {
+					if (caa_unlikely(n > (int64_t) global_sum_step))
+						move_sum = (int64_t) global_sum_step / 2;
+					else if (caa_unlikely(n < -(int64_t) global_sum_step))
+						move_sum = -((int64_t) global_sum_step / 2);
+					n -= move_sum;
+				}
 				res = uatomic_cmpxchg(int_p, old, n);
 			} while (old != res);
 			break;