From: David Goulet Date: Fri, 28 Mar 2014 13:58:03 +0000 (-0400) Subject: Fix: take session list lock when listing tp X-Git-Tag: v2.4.1~4 X-Git-Url: http://git.lttng.org./?a=commitdiff_plain;h=a5b55f387c87048e4154fff9ed58124ae860a9c7;p=lttng-tools.git Fix: take session list lock when listing tp This is important since the list tracepoints command access the application socket to ask the application for its TPs. The session list lock protects the ordering of message for those sockets. This was triggering out of order message between the session daemon and an application thus triggering undefined behavior. Fixes #774 Signed-off-by: David Goulet --- diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c index a65d62bfa..09d46d3ee 100644 --- a/src/bin/lttng-sessiond/main.c +++ b/src/bin/lttng-sessiond/main.c @@ -3055,7 +3055,9 @@ skip_domain: struct lttng_event *events; ssize_t nb_events; + session_lock_list(); nb_events = cmd_list_tracepoints(cmd_ctx->lsm->domain.type, &events); + session_unlock_list(); if (nb_events < 0) { /* Return value is a negative lttng_error_code. */ ret = -nb_events; @@ -3086,8 +3088,10 @@ skip_domain: struct lttng_event_field *fields; ssize_t nb_fields; + session_lock_list(); nb_fields = cmd_list_tracepoint_fields(cmd_ctx->lsm->domain.type, &fields); + session_unlock_list(); if (nb_fields < 0) { /* Return value is a negative lttng_error_code. */ ret = -nb_fields;