From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Date: Mon, 19 Jul 2021 21:17:39 +0000 (-0400)
Subject: Fix: sessiond: notification: missing unlock on client skip
X-Git-Tag: v2.13.0~2
X-Git-Url: http://git.lttng.org./?a=commitdiff_plain;h=61883fe45e4389fd4fd6ca4c869cc384b4185637;hp=61883fe45e4389fd4fd6ca4c869cc384b4185637;p=lttng-tools.git

Fix: sessiond: notification: missing unlock on client skip

Skipping a client must be performed by using the dedicated "skip_client"
label which will unlock the client's lock before continuing the loop
rather than using 'continue' directly.

Currently, a client will remain locked when an hidden trigger emits
a notification to which it is subscribed.

1458230 Missing unlock

May result in deadlock if there is another attempt to acquire the lock.

In notification_client_list_send_evaluation: Missing a release of a lock
on a path (CWE-667)

Reported-by: Coverity Scan
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I8b69395b91b0ea59ae5e0beadebd9099db623121
---