X-Git-Url: http://git.lttng.org./?a=blobdiff_plain;f=tests%2Ftest_urcu_ja.c;h=7230ec6d8398e2a44eefc5470b33775a782e4590;hb=21ac4c56cd0edffc0590b649b6ed1e7b61269b20;hp=a4e7d0efae69127f8cd00746020a91b1d694cb45;hpb=04c48ddf315c0dce15c6199eecd2a3006103d69f;p=userspace-rcu.git

diff --git a/tests/test_urcu_ja.c b/tests/test_urcu_ja.c
index a4e7d0e..7230ec6 100644
--- a/tests/test_urcu_ja.c
+++ b/tests/test_urcu_ja.c
@@ -78,6 +78,9 @@ static int add_unique, add_replace;
 
 static pthread_mutex_t rcu_copy_mutex = PTHREAD_MUTEX_INITIALIZER;
 
+static int leak_detection;
+static unsigned long test_nodes_allocated, test_nodes_freed;
+
 void set_affinity(void)
 {
 	cpu_set_t mask;
@@ -130,11 +133,45 @@ void rcu_copy_mutex_unlock(void)
 	}
 }
 
+static
+struct ja_test_node *node_alloc(void)
+{
+	struct ja_test_node *node;
+
+	node = calloc(sizeof(*node), 1);
+	if (leak_detection && node)
+		uatomic_inc(&test_nodes_allocated);
+	return node;
+}
+
+static
+void free_node(struct ja_test_node *node)
+{
+	poison_free(node);
+	if (leak_detection)
+		uatomic_inc(&test_nodes_freed);
+}
+
+static
 void free_node_cb(struct rcu_head *head)
 {
 	struct ja_test_node *node =
-		caa_container_of(head, struct ja_test_node, node.head);
-	poison_free(node);
+		caa_container_of(head, struct ja_test_node, head);
+	free_node(node);
+}
+
+static
+void rcu_free_test_node(struct ja_test_node *test_node)
+{
+	call_rcu(&test_node->head, free_node_cb);
+}
+
+static
+void rcu_free_node(struct cds_ja_node *node)
+{
+	struct ja_test_node *test_node = to_test_node(node);
+
+	rcu_free_test_node(test_node);
 }
 
 #if 0
@@ -182,15 +219,17 @@ printf("        [not -u nor -s] Add entries (supports redundant keys).\n");
 	printf("        [-t] Do sanity test.\n");
 	printf("        [-B] Key bits for multithread test (default: 32).\n");
 	printf("        [-m factor] Key multiplication factor.\n");
+	printf("	[-l] Memory leak detection.\n");
 	printf("\n\n");
 }
 
-
 static
 int test_8bit_key(void)
 {
-	int ret;
+	int ret, i;
 	uint64_t key;
+	uint64_t ka[] = { 4, 17, 100, 222 };
+	uint64_t ka_test_offset = 5;
 
 	/* Test with 8-bit key */
 	test_ja = cds_ja_new(8);
@@ -202,8 +241,7 @@ int test_8bit_key(void)
 	/* Add keys */
 	printf("Test #1: add keys (8-bit).\n");
 	for (key = 0; key < 200; key++) {
-		struct ja_test_node *node =
-			calloc(sizeof(*node), 1);
+		struct ja_test_node *node = node_alloc();
 
 		ja_test_node_init(node, key);
 		rcu_read_lock();
@@ -262,7 +300,7 @@ int test_8bit_key(void)
 			fprintf(stderr, "Error (%d) removing node %" PRIu64 "\n", ret, key);
 			assert(0);
 		}
-		call_rcu(&node->node.head, free_node_cb);
+		rcu_free_test_node(node);
 		head = cds_ja_lookup(test_ja, key);
 		if (!cds_hlist_empty(&head)) {
 			fprintf(stderr, "Error lookup %" PRIu64 ": %p (after delete) failed. Node is not expected.\n", key, head.next);
@@ -272,7 +310,68 @@ int test_8bit_key(void)
 	}
 	printf("OK\n");
 
-	ret = cds_ja_destroy(test_ja, free_node_cb);
+	printf("Test #5: lookup lower equal (8-bit).\n");
+
+	for (i = 0; i < CAA_ARRAY_SIZE(ka); i++) {
+		struct ja_test_node *node = node_alloc();
+
+		key = ka[i];
+		ja_test_node_init(node, key);
+		rcu_read_lock();
+		ret = cds_ja_add(test_ja, key, &node->node);
+		rcu_read_unlock();
+		if (ret) {
+			fprintf(stderr, "Error (%d) adding node %" PRIu64 "\n",
+				ret, key);
+			assert(0);
+		}
+	}
+
+	for (i = 0; i < CAA_ARRAY_SIZE(ka); i++) {
+		struct cds_hlist_head head;
+		struct ja_test_node *node;
+
+		key = ka[i] + ka_test_offset;
+		rcu_read_lock();
+		head = cds_ja_lookup_lower_equal(test_ja, key);
+		if (cds_hlist_empty(&head)) {
+			fprintf(stderr, "Error lookup lower equal. Cannot find expected key %" PRIu64" below or equal to %" PRIu64 ".\n",
+				ka[i], key);
+			assert(0);
+		}
+		node = cds_hlist_first_entry_rcu(&head, struct ja_test_node, node.list);
+		if (node->key != ka[i]) {
+			fprintf(stderr, "Error lookup lower equal. Expecting key %" PRIu64 " below or equal to %" PRIu64 ", but found %" PRIu64 " instead.\n",
+				ka[i], key, node->key);
+			assert(0);
+		}
+		rcu_read_unlock();
+	}
+
+	for (i = 0; i < CAA_ARRAY_SIZE(ka); i++) {
+		struct cds_hlist_head head;
+		struct ja_test_node *node;
+
+		key = ka[i];	/* without offset */
+		rcu_read_lock();
+		head = cds_ja_lookup_lower_equal(test_ja, key);
+		if (cds_hlist_empty(&head)) {
+			fprintf(stderr, "Error lookup lower equal. Cannot find expected key %" PRIu64" below or equal to %" PRIu64 ".\n",
+				ka[i], key);
+			assert(0);
+		}
+		node = cds_hlist_first_entry_rcu(&head, struct ja_test_node, node.list);
+		if (node->key != ka[i]) {
+			fprintf(stderr, "Error lookup lower equal. Expecting key %" PRIu64 " below or equal to %" PRIu64 ", but found %" PRIu64 " instead.\n",
+				ka[i], key, node->key);
+			assert(0);
+		}
+		rcu_read_unlock();
+	}
+
+	printf("OK\n");
+
+	ret = cds_ja_destroy(test_ja, rcu_free_node);
 	if (ret) {
 		fprintf(stderr, "Error destroying judy array\n");
 		return -1;
@@ -283,8 +382,10 @@ int test_8bit_key(void)
 static
 int test_16bit_key(void)
 {
-	int ret;
+	int ret, i;
 	uint64_t key;
+	uint64_t ka[] = { 4, 105, 222, 4000, 4111, 59990, 65435 };
+	uint64_t ka_test_offset = 100;
 
 	/* Test with 16-bit key */
 	test_ja = cds_ja_new(16);
@@ -297,8 +398,7 @@ int test_16bit_key(void)
 	printf("Test #1: add keys (16-bit).\n");
 	for (key = 0; key < 10000; key++) {
 	//for (key = 0; key < 65536; key+=256) {
-		struct ja_test_node *node =
-			calloc(sizeof(*node), 1);
+		struct ja_test_node *node = node_alloc();
 
 		ja_test_node_init(node, key);
 		rcu_read_lock();
@@ -359,7 +459,7 @@ int test_16bit_key(void)
 			fprintf(stderr, "Error (%d) removing node %" PRIu64 "\n", ret, key);
 			assert(0);
 		}
-		call_rcu(&node->node.head, free_node_cb);
+		rcu_free_test_node(node);
 		head = cds_ja_lookup(test_ja, key);
 		if (!cds_hlist_empty(&head)) {
 			fprintf(stderr, "Error lookup %" PRIu64 ": %p (after delete) failed. Node is not expected.\n", key, head.next);
@@ -369,7 +469,68 @@ int test_16bit_key(void)
 	}
 	printf("OK\n");
 
-	ret = cds_ja_destroy(test_ja, free_node_cb);
+	printf("Test #5: lookup lower equal (16-bit).\n");
+
+	for (i = 0; i < CAA_ARRAY_SIZE(ka); i++) {
+		struct ja_test_node *node = node_alloc();
+
+		key = ka[i];
+		ja_test_node_init(node, key);
+		rcu_read_lock();
+		ret = cds_ja_add(test_ja, key, &node->node);
+		rcu_read_unlock();
+		if (ret) {
+			fprintf(stderr, "Error (%d) adding node %" PRIu64 "\n",
+				ret, key);
+			assert(0);
+		}
+	}
+
+	for (i = 0; i < CAA_ARRAY_SIZE(ka); i++) {
+		struct cds_hlist_head head;
+		struct ja_test_node *node;
+
+		key = ka[i] + ka_test_offset;
+		rcu_read_lock();
+		head = cds_ja_lookup_lower_equal(test_ja, key);
+		if (cds_hlist_empty(&head)) {
+			fprintf(stderr, "Error lookup lower equal. Cannot find expected key %" PRIu64" below or equal to %" PRIu64 ".\n",
+				ka[i], key);
+			assert(0);
+		}
+		node = cds_hlist_first_entry_rcu(&head, struct ja_test_node, node.list);
+		if (node->key != ka[i]) {
+			fprintf(stderr, "Error lookup lower equal. Expecting key %" PRIu64 " below or equal to %" PRIu64 ", but found %" PRIu64 " instead.\n",
+				ka[i], key, node->key);
+			assert(0);
+		}
+		rcu_read_unlock();
+	}
+
+	for (i = 0; i < CAA_ARRAY_SIZE(ka); i++) {
+		struct cds_hlist_head head;
+		struct ja_test_node *node;
+
+		key = ka[i];	/* without offset */
+		rcu_read_lock();
+		head = cds_ja_lookup_lower_equal(test_ja, key);
+		if (cds_hlist_empty(&head)) {
+			fprintf(stderr, "Error lookup lower equal. Cannot find expected key %" PRIu64" below or equal to %" PRIu64 ".\n",
+				ka[i], key);
+			assert(0);
+		}
+		node = cds_hlist_first_entry_rcu(&head, struct ja_test_node, node.list);
+		if (node->key != ka[i]) {
+			fprintf(stderr, "Error lookup lower equal. Expecting key %" PRIu64 " below or equal to %" PRIu64 ", but found %" PRIu64 " instead.\n",
+				ka[i], key, node->key);
+			assert(0);
+		}
+		rcu_read_unlock();
+	}
+
+	printf("OK\n");
+
+	ret = cds_ja_destroy(test_ja, rcu_free_node);
 	if (ret) {
 		fprintf(stderr, "Error destroying judy array\n");
 		return -1;
@@ -404,8 +565,7 @@ int test_sparse_key(unsigned int bits, int nr_dup)
 	for (i = 0; i < nr_dup; i++) {
 		zerocount = 0;
 		for (key = 0; key <= max_key && (key != 0 || zerocount < 1); key += 1ULL << (bits - 8)) {
-			struct ja_test_node *node =
-				calloc(sizeof(*node), 1);
+			struct ja_test_node *node = node_alloc();
 
 			ja_test_node_init(node, key);
 			rcu_read_lock();
@@ -467,7 +627,7 @@ int test_sparse_key(unsigned int bits, int nr_dup)
 		}
 		printf("OK\n");
 	}
-	printf("Test #4: remove keys (16-bit).\n");
+	printf("Test #4: remove keys (%u-bit).\n", bits);
 	zerocount = 0;
 	for (key = 0; key <= max_key && (key != 0 || zerocount < 1); key += 1ULL << (bits - 8)) {
 		struct cds_hlist_head head;
@@ -492,7 +652,7 @@ int test_sparse_key(unsigned int bits, int nr_dup)
 				fprintf(stderr, "Error (%d) removing node %" PRIu64 "\n", ret, key);
 				assert(0);
 			}
-			call_rcu(&node->node.head, free_node_cb);
+			rcu_free_test_node(node);
 			testhead = cds_ja_lookup(test_ja, key);
 			if (count < nr_dup && cds_hlist_empty(&testhead)) {
 				fprintf(stderr, "Error: no node found after deletion of some nodes of a key\n");
@@ -510,7 +670,7 @@ int test_sparse_key(unsigned int bits, int nr_dup)
 	}
 	printf("OK\n");
 
-	ret = cds_ja_destroy(test_ja, free_node_cb);
+	ret = cds_ja_destroy(test_ja, rcu_free_node);
 	if (ret) {
 		fprintf(stderr, "Error destroying judy array\n");
 		return -1;
@@ -669,7 +829,7 @@ void *test_ja_rw_thr_writer(void *_count)
 	for (;;) {
 		if ((addremove == AR_ADD)
 				|| (addremove == AR_RANDOM && is_add())) {
-			struct ja_test_node *node = malloc(sizeof(*node));
+			struct ja_test_node *node = node_alloc();
 			struct cds_ja_node *ret_node;
 
 			/* note: only inserting ulong keys */
@@ -680,7 +840,7 @@ void *test_ja_rw_thr_writer(void *_count)
 			if (add_unique) {
 				ret_node = cds_ja_add_unique(test_ja, key, &node->node);
 				if (ret_node != &node->node) {
-					free(node);
+					free_node(node);
 					URCU_TLS(nr_addexist)++;
 				} else {
 					URCU_TLS(nr_add)++;
@@ -691,7 +851,7 @@ void *test_ja_rw_thr_writer(void *_count)
 				ret = cds_ja_add(test_ja, key, &node->node);
 				if (ret) {
 					fprintf(stderr, "Error in cds_ja_add: %d\n", ret);
-					free(node);
+					free_node(node);
 				} else {
 					URCU_TLS(nr_add)++;
 				}
@@ -712,7 +872,7 @@ void *test_ja_rw_thr_writer(void *_count)
 			if (node) {
 				ret = cds_ja_del(test_ja, key, &node->node);
 				if (!ret) {
-					call_rcu(&node->node.head, free_node_cb);
+					rcu_free_test_node(node);
 					URCU_TLS(nr_del)++;
 				} else {
 					URCU_TLS(nr_delnoent)++;
@@ -760,7 +920,7 @@ int do_mt_populate_ja(void)
 	printf("Starting rw test\n");
 
 	for (iter = init_pool_offset; iter < init_pool_offset + init_pool_size; iter++) {
-		struct ja_test_node *node = malloc(sizeof(*node));
+		struct ja_test_node *node = node_alloc();
 		uint64_t key;
 
 		/* note: only inserting ulong keys */
@@ -855,7 +1015,7 @@ int do_mt_test(void)
 	}
 	rcu_thread_online_qsbr();
 
-	ret = cds_ja_destroy(test_ja, free_node_cb);
+	ret = cds_ja_destroy(test_ja, rcu_free_node);
 	if (ret) {
 		fprintf(stderr, "Error destroying judy array\n");
 		goto end;
@@ -870,6 +1030,21 @@ end:
 	return ret;
 }
 
+static
+int check_memory_leaks(void)
+{
+	unsigned long na, nf;
+
+	na = uatomic_read(&test_nodes_allocated);
+	nf = uatomic_read(&test_nodes_freed);
+	if (na != nf) {
+		fprintf(stderr, "Memory leak of %ld test nodes detected. Allocated: %lu, freed: %lu\n",
+			na - nf, na, nf);
+		return -1;
+	}
+	return 0;
+}
+
 int main(int argc, char **argv)
 {
 	int i, j, a, ret, err;
@@ -980,6 +1155,9 @@ int main(int argc, char **argv)
 		case 's':
 			add_replace = 1;
 			break;
+		case 'l':
+			leak_detection = 1;
+			break;
 		}
 	}
 
@@ -998,6 +1176,10 @@ int main(int argc, char **argv)
 		lookup_pool_offset, lookup_pool_size);
 	printf_verbose("Update pool size offset %lu size %lu.\n",
 		write_pool_offset, write_pool_size);
+	if (validate_lookup)
+		printf_verbose("Validating lookups.\n");
+	if (leak_detection)
+		printf_verbose("Memory leak dection activated.\n");
 	printf_verbose("thread %-6s, thread id : %lx, tid %lu\n",
 			"main", pthread_self(), (unsigned long)gettid());
 
@@ -1028,6 +1210,11 @@ int main(int argc, char **argv)
 		ret = do_mt_test();
 	}
 
+	/* Wait for in-flight call_rcu free to complete for leak detection */
+	rcu_barrier();
+
+	ret |= check_memory_leaks();
+
 	rcu_unregister_thread();
 	free_all_cpu_call_rcu_data();
 
@@ -1035,69 +1222,4 @@ int main(int argc, char **argv)
 		printf("Test ended with error: %d\n", ret);
 	}
 	return ret;
-
-#if 0
-	/*
-	 * Hash Population needs to be seen as a RCU reader
-	 * thread from the point of view of resize.
-	 */
-	rcu_register_thread();
-      	ret = (get_populate_hash_cb())();
-	assert(!ret);
-
-	rcu_thread_offline();
-
-	/* teardown counter thread */
-	act.sa_handler = SIG_IGN;
-	act.sa_flags = SA_RESTART;
-	ret = sigaction(SIGUSR2, &act, NULL);
-	if (ret == -1) {
-		perror("sigaction");
-		return -1;
-	}
-	{
-		char msg[1] = { 0x42 };
-		ssize_t ret;
-
-		do {
-			ret = write(count_pipe[1], msg, 1);	/* wakeup thread */
-		} while (ret == -1L && errno == EINTR);
-	}
-
-	fflush(stdout);
-	rcu_thread_online();
-	rcu_read_lock();
-	printf("Counting nodes... ");
-	cds_lfht_count_nodes(test_ht, &approx_before, &count, &approx_after);
-	printf("done.\n");
-	test_delete_all_nodes(test_ht);
-	rcu_read_unlock();
-	rcu_thread_offline();
-	if (count) {
-		printf("Approximation before node accounting: %ld nodes.\n",
-			approx_before);
-		printf("Nodes deleted from hash table before destroy: "
-			"%lu nodes.\n",
-			count);
-		printf("Approximation after node accounting: %ld nodes.\n",
-			approx_after);
-	}
-	ret = cds_lfht_destroy(test_ht, NULL);
-	if (ret)
-		printf_verbose("final delete aborted\n");
-	else
-		printf_verbose("final delete success\n");
-	printf_verbose("total number of reads : %llu, writes %llu\n", tot_reads,
-	       tot_writes);
-	printf("SUMMARY %-25s testdur %4lu nr_readers %3u rdur %6lu "
-		"nr_writers %3u "
-		"wdelay %6lu nr_reads %12llu nr_writes %12llu nr_ops %12llu "
-		"nr_add %12llu nr_add_fail %12llu nr_remove %12llu nr_leaked %12lld\n",
-		argv[0], duration, nr_readers, rduration,
-		nr_writers, wdelay, tot_reads, tot_writes,
-		tot_reads + tot_writes, tot_add, tot_add_exist, tot_remove,
-		(long long) tot_add + init_populate - tot_remove - count);
-	rcu_unregister_thread();
-#endif
-	return 0;
 }