X-Git-Url: http://git.lttng.org./?a=blobdiff_plain;f=src%2Flttng-syscalls.c;h=0528404063f8e2b123ca6b632f5b100fa1a2cf4f;hb=092ffe9764a1f127a33dc8eed682f7cd5e81bed1;hp=6d0f3554509a74304a6db6cd74210a9c1bb9a6db;hpb=badfe9f5c396efb1b00e5f2abcded2e4ac4a5bac;p=lttng-modules.git

diff --git a/src/lttng-syscalls.c b/src/lttng-syscalls.c
index 6d0f3554..05284040 100644
--- a/src/lttng-syscalls.c
+++ b/src/lttng-syscalls.c
@@ -721,7 +721,7 @@ int fill_table(const struct trace_syscall_entry *table, size_t table_len,
 			ev.u.syscall.abi = LTTNG_KERNEL_SYSCALL_ABI_COMPAT;
 			break;
 		}
-		strncpy(ev.name, desc->name, LTTNG_KERNEL_SYM_NAME_LEN);
+		strncpy(ev.name, desc->name, LTTNG_KERNEL_SYM_NAME_LEN - 1);
 		ev.name[LTTNG_KERNEL_SYM_NAME_LEN - 1] = '\0';
 		ev.instrumentation = LTTNG_KERNEL_SYSCALL;
 		chan_table[i] = _lttng_event_create(chan, &ev, filter,
@@ -1059,7 +1059,6 @@ int lttng_syscall_filter_enable(struct lttng_channel *chan,
 	if (syscall_nr < 0)
 		return -ENOENT;
 
-
 	switch (event->u.syscall.entryexit) {
 	case LTTNG_SYSCALL_ENTRY:
 		switch (event->u.syscall.abi) {
@@ -1069,6 +1068,8 @@ int lttng_syscall_filter_enable(struct lttng_channel *chan,
 		case LTTNG_SYSCALL_ABI_COMPAT:
 			bitmap = filter->sc_compat_entry;
 			break;
+		default:
+			return -EINVAL;
 		}
 		break;
 	case LTTNG_SYSCALL_EXIT:
@@ -1079,6 +1080,8 @@ int lttng_syscall_filter_enable(struct lttng_channel *chan,
 		case LTTNG_SYSCALL_ABI_COMPAT:
 			bitmap = filter->sc_compat_exit;
 			break;
+		default:
+			return -EINVAL;
 		}
 		break;
 	default:
@@ -1115,7 +1118,6 @@ int lttng_syscall_filter_disable(struct lttng_channel *chan,
 	if (syscall_nr < 0)
 		return -ENOENT;
 
-
 	switch (event->u.syscall.entryexit) {
 	case LTTNG_SYSCALL_ENTRY:
 		switch (event->u.syscall.abi) {
@@ -1125,6 +1127,8 @@ int lttng_syscall_filter_disable(struct lttng_channel *chan,
 		case LTTNG_SYSCALL_ABI_COMPAT:
 			bitmap = filter->sc_compat_entry;
 			break;
+		default:
+			return -EINVAL;
 		}
 		break;
 	case LTTNG_SYSCALL_EXIT:
@@ -1135,6 +1139,8 @@ int lttng_syscall_filter_disable(struct lttng_channel *chan,
 		case LTTNG_SYSCALL_ABI_COMPAT:
 			bitmap = filter->sc_compat_exit;
 			break;
+		default:
+			return -EINVAL;
 		}
 		break;
 	default: