X-Git-Url: http://git.lttng.org./?a=blobdiff_plain;f=src%2Fcommon%2Fsession-descriptor.c;h=8b475909c43b771958bcfba9d75e62b98a6ea583;hb=395004a13b038fde13364a662d735d16937ea2d1;hp=f111320e44c564b7b202cf39e2bc1260da85ecae;hpb=ab5be9fa2eb5ba9600a82cd18fd3cfcbac69169a;p=lttng-tools.git

diff --git a/src/common/session-descriptor.c b/src/common/session-descriptor.c
index f111320e4..8b475909c 100644
--- a/src/common/session-descriptor.c
+++ b/src/common/session-descriptor.c
@@ -1,7 +1,7 @@
 /*
  * Copyright (C) 2019 Jérémie Galarneau <jeremie.galarneau@efficios.com>
  *
- * SPDX-License-Identifier: GPL-2.0-only
+ * SPDX-License-Identifier: LGPL-2.1-only
  */
 
 #include <lttng/session-descriptor-internal.h>
@@ -616,12 +616,12 @@ ssize_t lttng_session_descriptor_create_from_buffer(
 
 	current_view = lttng_buffer_view_from_view(payload, offset,
 			sizeof(*base_header));
-	base_header = (typeof(base_header)) current_view.data;
-	if (!base_header) {
+	if (!lttng_buffer_view_is_valid(&current_view)) {
 		ret = -1;
 		goto end;
 	}
 
+	base_header = (typeof(base_header)) current_view.data;
 	switch (base_header->type) {
 	case LTTNG_SESSION_DESCRIPTOR_TYPE_REGULAR:
 	case LTTNG_SESSION_DESCRIPTOR_TYPE_SNAPSHOT:
@@ -632,12 +632,12 @@ ssize_t lttng_session_descriptor_create_from_buffer(
 
 		current_view = lttng_buffer_view_from_view(payload, offset,
 				sizeof(*live_header));
-		live_header = (typeof(live_header)) current_view.data;
-		if (!live_header) {
+		if (!lttng_buffer_view_is_valid(&current_view)) {
 			ret = -1;
 			goto end;
 		}
 
+		live_header = (typeof(live_header)) current_view.data;
 		live_timer_us = live_header->live_timer_us;
 		break;
 	}
@@ -674,12 +674,12 @@ ssize_t lttng_session_descriptor_create_from_buffer(
 	/* Map the name. */
 	current_view = lttng_buffer_view_from_view(payload, offset,
 			base_header->name_len);
-	name = current_view.data;
-	if (!name) {
+	if (!lttng_buffer_view_is_valid(&current_view)) {
 		ret = -1;
 		goto end;
 	}
 
+	name = current_view.data;
 	if (base_header->name_len == 1 ||
 			name[base_header->name_len - 1] ||
 			strlen(name) != base_header->name_len - 1) {
@@ -705,11 +705,12 @@ skip_name:
 		/* Map a URI. */
 		current_view = lttng_buffer_view_from_view(payload,
 				offset, sizeof(*uri));
-		uri = (typeof(uri)) current_view.data;
-		if (!uri) {
+		if (!lttng_buffer_view_is_valid(&current_view)) {
 			ret = -1;
 			goto end;
 		}
+
+		uri = (typeof(uri)) current_view.data;
 		uris[i] = zmalloc(sizeof(*uri));
 		if (!uris[i]) {
 			ret = -1;