X-Git-Url: http://git.lttng.org./?a=blobdiff_plain;f=src%2Fbin%2Flttng-sessiond%2Fagent-thread.c;h=de5fd8de8a80cf851f291a0b5c2ed7fabf1825b6;hb=2198c1e1b48c9c98f17cce24adde8408b5cd1c64;hp=4c1457fe0df7a6fed32ce8141a1474e4cc2d531e;hpb=75a919034ca77a989248128265314af7776fa766;p=lttng-tools.git

diff --git a/src/bin/lttng-sessiond/agent-thread.c b/src/bin/lttng-sessiond/agent-thread.c
index 4c1457fe0..de5fd8de8 100644
--- a/src/bin/lttng-sessiond/agent-thread.c
+++ b/src/bin/lttng-sessiond/agent-thread.c
@@ -27,6 +27,7 @@
 
 #include "fd-limit.h"
 #include "agent-thread.h"
+#include "agent.h"
 #include "lttng-sessiond.h"
 #include "session.h"
 #include "utils.h"
@@ -72,53 +73,6 @@ static void update_agent_app(struct agent_app *app)
 	session_unlock_list();
 }
 
-/*
- * Destroy a agent application by socket.
- */
-static void destroy_agent_app(int sock)
-{
-	struct agent_app *app;
-
-	assert(sock >= 0);
-
-	/*
-	 * Not finding an application is a very important error that should NEVER
-	 * happen. The hash table deletion is ONLY done through this call even on
-	 * thread cleanup.
-	 */
-	rcu_read_lock();
-	app = agent_find_app_by_sock(sock);
-	assert(app);
-	rcu_read_unlock();
-
-	/* RCU read side lock is taken in this function call. */
-	agent_delete_app(app);
-
-	/* The application is freed in a RCU call but the socket is closed here. */
-	agent_destroy_app(app);
-}
-
-/*
- * Cleanup remaining agent apps in the hash table. This should only be called in
- * the exit path of the thread.
- */
-static void clean_agent_apps_ht(void)
-{
-	struct lttng_ht_node_ulong *node;
-	struct lttng_ht_iter iter;
-
-	DBG3("[agent-thread] Cleaning agent apps ht");
-
-	rcu_read_lock();
-	cds_lfht_for_each_entry(agent_apps_ht_by_sock->ht, &iter.iter, node, node) {
-		struct agent_app *app;
-
-		app = caa_container_of(node, struct agent_app, node);
-		destroy_agent_app(app->sock->fd);
-	}
-	rcu_read_unlock();
-}
-
 /*
  * Create and init socket from uri.
  */
@@ -352,7 +306,7 @@ restart:
 					goto error;
 				}
 
-				destroy_agent_app(pollfd);
+				agent_destroy_app_by_sock(pollfd);
 			} else if (revents & (LPOLLIN)) {
 				int new_fd;
 				struct agent_app *app = NULL;
@@ -373,7 +327,7 @@ restart:
 				ret = lttng_poll_add(&events, new_fd,
 						LPOLLERR | LPOLLHUP | LPOLLRDHUP);
 				if (ret < 0) {
-					destroy_agent_app(new_fd);
+					agent_destroy_app_by_sock(new_fd);
 					continue;
 				}
 
@@ -399,11 +353,6 @@ error_tcp_socket:
 error_poll_create:
 	DBG("[agent-thread] is cleaning up and stopping.");
 
-	if (agent_apps_ht_by_sock) {
-		clean_agent_apps_ht();
-		lttng_ht_destroy(agent_apps_ht_by_sock);
-	}
-
 	rcu_thread_offline();
 	rcu_unregister_thread();
 	return NULL;