X-Git-Url: http://git.lttng.org./?a=blobdiff_plain;f=libustcomm%2Fustcomm.c;h=8b459df32975499a4c1137ee379fb9d40600b231;hb=e7465adb1683ce0201f7e029efb48c7fac2b7b63;hp=630f90609cb403ec136f8120edb8b85c171f99ee;hpb=08230db7e2e536bddf0015fa663b6d10abea30f1;p=lttng-ust.git

diff --git a/libustcomm/ustcomm.c b/libustcomm/ustcomm.c
index 630f9060..8b459df3 100644
--- a/libustcomm/ustcomm.c
+++ b/libustcomm/ustcomm.c
@@ -23,6 +23,7 @@
 #include <sys/un.h>
 #include <unistd.h>
 #include <poll.h>
+#include <sys/stat.h>
 
 #include <stdio.h>
 #include <stdlib.h>
@@ -109,8 +110,18 @@ int ustcomm_request_consumer(pid_t pid, const char *channel)
 	char *msg=NULL;
 	int retval = 0;
 	struct ustcomm_connection conn;
+	char *explicit_daemon_socket_path;
+
+	explicit_daemon_socket_path = getenv("UST_DAEMON_SOCKET");
+	if(explicit_daemon_socket_path) {
+		/* user specified explicitly a socket path */
+		result = snprintf(path, UNIX_PATH_MAX, "%s", explicit_daemon_socket_path);
+	}
+	else {
+		/* just use the default path */
+		result = snprintf(path, UNIX_PATH_MAX, "%s/ustd", SOCK_DIR);
+	}
 
-	result = snprintf(path, UNIX_PATH_MAX, "%s/ustd", SOCK_DIR);
 	if(result >= UNIX_PATH_MAX) {
 		ERR("string overflow allocating socket name");
 		return -1;
@@ -181,6 +192,23 @@ int ustcomm_send_reply(struct ustcomm_server *server, char *msg, struct ustcomm_
 	return 0;
 } 
 
+/* Called after a fork. */
+
+int ustcomm_close_all_connections(struct ustcomm_server *server)
+{
+	struct ustcomm_connection *conn;
+	struct ustcomm_connection *deletable_conn = NULL;
+
+	list_for_each_entry(conn, &server->connections, list) {
+		free(deletable_conn);
+		deletable_conn = conn;
+		close(conn->fd);
+		list_del(&conn->list);
+	}
+
+	return 0;
+}
+
 /* @timeout: max blocking time in milliseconds, -1 means infinity
  *
  * returns 1 to indicate a message was received
@@ -351,8 +379,7 @@ static int init_named_socket(const char *name, char **path_out)
 	}
 
 	if(path_out) {
-		*path_out = "";
-		*path_out = strdupa(addr.sun_path);
+		*path_out = strdup(addr.sun_path);
 	}
 
 	return fd;
@@ -363,13 +390,24 @@ static int init_named_socket(const char *name, char **path_out)
 	return -1;
 }
 
+/*
+ * Return value:
+ *   0: Success, but no reply because recv() returned 0
+ *   1: Success
+ *   -1: Error
+ *
+ * On error, the error message is printed, except on
+ * ECONNRESET, which is normal when the application dies.
+ */
+
 int ustcomm_send_request(struct ustcomm_connection *conn, const char *req, char **reply)
 {
 	int result;
 
-	result = send(conn->fd, req, strlen(req), 0);
+	result = send(conn->fd, req, strlen(req), MSG_NOSIGNAL);
 	if(result == -1) {
-		PERROR("send");
+		if(errno != ECONNRESET)
+			PERROR("send");
 		return -1;
 	}
 
@@ -379,7 +417,8 @@ int ustcomm_send_request(struct ustcomm_connection *conn, const char *req, char
 	*reply = (char *) malloc(MSG_MAX+1);
 	result = recv(conn->fd, *reply, MSG_MAX, 0);
 	if(result == -1) {
-		PERROR("recv");
+		if(errno != ECONNRESET)
+			PERROR("recv");
 		return -1;
 	}
 	else if(result == 0) {
@@ -485,31 +524,56 @@ free_name:
  * can connect to it.
  */
 
-int ustcomm_init_ustd(struct ustcomm_ustd *handle)
+int ustcomm_init_ustd(struct ustcomm_ustd *handle, const char *sock_path)
 {
-	int result;
 	char *name;
+	int retval = 0;
 
-	result = asprintf(&name, "%s/%s", SOCK_DIR, "ustd");
-	if(result >= UNIX_PATH_MAX) {
-		ERR("string overflow allocating socket name");
-		return -1;
+	if(sock_path) {
+		asprintf(&name, "%s", sock_path);
+	}
+	else {
+		asprintf(&name, "%s/%s", SOCK_DIR, "ustd");
 	}
 
 	handle->server.listen_fd = init_named_socket(name, &handle->server.socketpath);
 	if(handle->server.listen_fd < 0) {
 		ERR("error initializing named socket at %s", name);
+		retval = -1;
 		goto free_name;
 	}
-	free(name);
 
 	INIT_LIST_HEAD(&handle->server.connections);
 
-	return 0;
-
 free_name:
 	free(name);
-	return -1;
+
+	return retval;
+}
+
+void ustcomm_fini_app(struct ustcomm_app *handle)
+{
+	int result;
+	struct stat st;
+
+	/* Destroy socket */
+	result = stat(handle->server.socketpath, &st);
+	if(result == -1) {
+		PERROR("stat (%s)", handle->server.socketpath);
+		return;
+	}
+
+	/* Paranoid check before deleting. */
+	result = S_ISSOCK(st.st_mode);
+	if(!result) {
+		ERR("The socket we are about to delete is not a socket.");
+		return;
+	}
+
+	result = unlink(handle->server.socketpath);
+	if(result == -1) {
+		PERROR("unlink");
+	}
 }
 
 static char *find_tok(char *str)