goto error;
}
- /* Duplicate the binary fd */
+ /*
+ * Duplicate the binary fd if possible. The binary fd can be -1 on
+ * listing
+ */
fd = lttng_userspace_probe_location_function_get_binary_fd(location);
- if (fd == -1) {
- ERR("Error getting file descriptor to binary");
- goto error;
- }
-
- new_fd = dup(fd);
- if (new_fd == -1) {
- PERROR("Error duplicating file descriptor to binary");
- goto error;
+ if (fd > -1) {
+ new_fd = dup(fd);
+ if (new_fd == -1) {
+ PERROR("Error duplicating file descriptor to binary");
+ goto error;
+ }
+ } else {
+ /* The original fd is not set. */
+ new_fd = -1;
}
/*
/* Duplicate the binary fd */
fd = lttng_userspace_probe_location_tracepoint_get_binary_fd(location);
- if (fd == -1) {
- ERR("Error getting file descriptor to binary");
- goto error;
- }
-
- new_fd = dup(fd);
- if (new_fd == -1) {
- PERROR("Error duplicating file descriptor to binary");
- goto error;
+ if (fd > -1) {
+ new_fd = dup(fd);
+ if (new_fd == -1) {
+ PERROR("Error duplicating file descriptor to binary");
+ goto error;
+ }
+ } else {
+ /* The original fd is not set. */
+ new_fd = -1;
}
/*
probe_name = lttng_strndup(probe_name_src, LTTNG_SYMBOL_NAME_LEN);
if (!probe_name) {
- PERROR("lttng_strndup");
+ PERROR("Failed to allocate probe name");
+ ret = -LTTNG_ERR_INVALID;
goto end;
}
provider_name = lttng_strndup(provider_name_src, LTTNG_SYMBOL_NAME_LEN);
if (!provider_name) {
- PERROR("lttng_strndup");
+ PERROR("Failed to allocate provider name");
+ ret = -LTTNG_ERR_INVALID;
goto end;
}
- binary_path = lttng_strndup(binary_path_src, LTTNG_SYMBOL_NAME_LEN);
+ binary_path = lttng_strndup(binary_path_src, LTTNG_PATH_MAX);
if (!binary_path) {
- PERROR("lttng_strndup");
+ PERROR("Failed to allocate binary path");
+ ret = -LTTNG_ERR_INVALID;
goto end;
}