-#!/bin/bash -exu
+#!/bin/bash
#
-# Copyright (C) 2015 - Michael Jeanson <mjeanson@efficios.com>
-# Jonathan Rajotte-Julien <jonathan.rajotte-julien@efficios.com>
-#
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program. If not, see <http://www.gnu.org/licenses/>.
+# SPDX-FileCopyrightText: 2015 Jonathan Rajotte-Julien <jonathan.rajotte-julien@efficios.com>
+# SPDX-FileCopyrightText: 2023 Michael Jeanson <mjeanson@efficios.com>
+# SPDX-License-Identifier: GPL-2.0-or-later
+
+set -exu
+
+# Required variables
+WORKSPACE=${WORKSPACE:-}
# Coverity settings
# The project name and token have to be provided trough env variables
COVERITY_SCAN_DESCRIPTION="Automated CI build"
COVERITY_SCAN_NOTIFICATION_EMAIL="ci-notification@lists.lttng.org"
COVERITY_SCAN_BUILD_OPTIONS=""
-#COVERITY_SCAN_BUILD_OPTIONS="--return-emit-failures 8 --parse-error-threshold 85"
+#COVERITY_SCAN_BUILD_OPTIONS=("--return-emit-failures 8" "--parse-error-threshold 85")
+
+DEPS_INC="$WORKSPACE/deps/build/include"
+DEPS_LIB="$WORKSPACE/deps/build/lib"
+DEPS_PKGCONFIG="$DEPS_LIB/pkgconfig"
+DEPS_BIN="$WORKSPACE/deps/build/bin"
+
+export PATH="$DEPS_BIN:$PATH"
+export LD_LIBRARY_PATH="$DEPS_LIB:${LD_LIBRARY_PATH:-}"
+export PKG_CONFIG_PATH="$DEPS_PKGCONFIG"
+export CPPFLAGS="-I$DEPS_INC"
+export LDFLAGS="-L$DEPS_LIB"
SRCDIR="$WORKSPACE/src/${COVERITY_SCAN_PROJECT_NAME}"
TMPDIR="$WORKSPACE/tmp"
NPROC=$(nproc)
PLATFORM=$(uname)
export CFLAGS="-O0 -g -DDEBUG"
+export CXXFLAGS="-O0 -g -DDEBUG"
-TOOL_ARCHIVE="$TMPDIR/cov-analysis-${PLATFORM}.tgz"
+# Cache the tool installer in the home directory since we delete the workspace
+# on each build
+TOOL_ARCHIVE="$HOME/cov-analysis-${PLATFORM}.tgz"
TOOL_URL=https://scan.coverity.com/download/${PLATFORM}
TOOL_BASE="$TMPDIR/coverity-scan-analysis"
case "$COVERITY_SCAN_PROJECT_NAME" in
babeltrace)
- CONF_OPTS="--enable-python-bindings --enable-python-bindings-doc --enable-python-plugins"
+ CONF_OPTS=("--enable-python-bindings" "--enable-python-bindings-doc" "--enable-python-plugins")
BUILD_TYPE="autotools"
;;
liburcu)
- CONF_OPTS=""
+ CONF_OPTS=()
BUILD_TYPE="autotools"
;;
lttng-modules)
- CONF_OPTS=""
+ CONF_OPTS=()
BUILD_TYPE="autotools"
;;
lttng-tools)
- CONF_OPTS=""
+ CONF_OPTS=()
BUILD_TYPE="autotools"
;;
lttng-ust)
- CONF_OPTS="--enable-java-agent-all --enable-python-agent"
+ CONF_OPTS=("--enable-java-agent-all" "--enable-python-agent")
BUILD_TYPE="autotools"
- export CLASSPATH="/usr/share/java/log4j-1.2.jar"
+ export CLASSPATH="/usr/share/java/log4j-api.jar:/usr/share/java/log4j-core.jar:/usr/share/java/log4j-1.2.jar"
;;
lttng-scope|ctf-java|libdelorean-java|jabberwocky)
- CONF_OPTS=""
+ CONF_OPTS=()
BUILD_TYPE="maven"
MVN_BIN="$HOME/tools/hudson.tasks.Maven_MavenInstallation/default/bin/mvn"
;;
-linux-rseq)
- CONF_OPTS=""
- BUILD_TYPE="linux-rseq"
- ;;
*)
echo "Generic project, no configure options."
- CONF_OPTS=""
+ CONF_OPTS=()
BUILD_TYPE="autotools"
;;
esac
-# liburcu dependency
-if [ -d "$WORKSPACE/deps/liburcu" ]; then
- URCU_INCS="$WORKSPACE/deps/liburcu/build/include/"
- URCU_LIBS="$WORKSPACE/deps/liburcu/build/lib/"
-
- export CPPFLAGS="-I$URCU_INCS ${CPPFLAGS:-}"
- export LDFLAGS="-L$URCU_LIBS ${LDFLAGS:-}"
- export LD_LIBRARY_PATH="$URCU_LIBS:${LD_LIBRARY_PATH:-}"
-fi
-
-
-# lttng-ust dependency
-if [ -d "$WORKSPACE/deps/lttng-ust" ]; then
- UST_INCS="$WORKSPACE/deps/lttng-ust/build/include/"
- UST_LIBS="$WORKSPACE/deps/lttng-ust/build/lib/"
-
- export CPPFLAGS="-I$UST_INCS ${CPPFLAGS:-}"
- export LDFLAGS="-L$UST_LIBS ${LDFLAGS:-}"
- export LD_LIBRARY_PATH="$UST_LIBS:${LD_LIBRARY_PATH:-}"
-fi
-
if [ -d "$WORKSPACE/src/linux" ]; then
export KERNELDIR="$WORKSPACE/src/linux"
fi
+# Enter the source directory
+cd "$SRCDIR"
# Verify upload is permitted
-# Added "--insecure" because Coverity can't be bothered to properly install SSL certificate chains
set +x
-AUTH_RES=$(curl -s --insecure --form project="$COVERITY_SCAN_PROJECT_NAME" --form token="$COVERITY_SCAN_TOKEN" $SCAN_URL/api/upload_permitted)
+AUTH_RES=$(curl --silent --form project="$COVERITY_SCAN_PROJECT_NAME" --form token="$COVERITY_SCAN_TOKEN" $SCAN_URL/api/upload_permitted)
set -x
if [ "$AUTH_RES" = "Access denied" ]; then
echo -e "\033[33;1mCoverity Scan API access denied. Check COVERITY_SCAN_PROJECT_NAME and COVERITY_SCAN_TOKEN.\033[0m"
# Download Coverity Scan Analysis Tool
if [ ! -d "$TOOL_BASE" ]; then
- if [ ! -e "$TOOL_ARCHIVE" ]; then
- echo -e "\033[33;1mDownloading Coverity Scan Analysis Tool...\033[0m"
- set +x
- curl -s --insecure --form project="$COVERITY_SCAN_PROJECT_NAME" --form token="$COVERITY_SCAN_TOKEN" -o "$TOOL_ARCHIVE" "$TOOL_URL"
- set -x
- fi
+ echo -e "\033[33;1mDownloading Coverity Scan Analysis Tool...\033[0m"
+ set +x
+ curl --fail --remote-time --continue-at - --form project="$COVERITY_SCAN_PROJECT_NAME" --form token="$COVERITY_SCAN_TOKEN" --output "$TOOL_ARCHIVE" --time-cond "$TOOL_ARCHIVE" "$TOOL_URL"
+ set -x
# Extract Coverity Scan Analysis Tool
echo -e "\033[33;1mExtracting Coverity Scan Analysis Tool...\033[0m"
TOOL_DIR=$(find "$TOOL_BASE" -type d -name 'cov-analysis*')
export PATH=$TOOL_DIR/bin:$PATH
-cd "$SRCDIR"
-
COVERITY_SCAN_VERSION=$(git describe --always | sed 's|-|.|g')
# Build
case "$BUILD_TYPE" in
maven)
cov-configure --java
- cov-build --dir "$RESULTS_DIR" $COVERITY_SCAN_BUILD_OPTIONS "$MVN_BIN" \
+ cov-build --dir "$RESULTS_DIR" "${COVERITY_SCAN_BUILD_OPTIONS[@]}" "$MVN_BIN" \
-s "$MVN_SETTINGS" \
-Dmaven.repo.local="$WORKSPACE/.repository" \
-Dmaven.compiler.fork=true \
# Prepare build dir for autotools based projects
if [ -f "./bootstrap" ]; then
./bootstrap
- ./configure $CONF_OPTS
+ ./configure "${CONF_OPTS[@]}"
fi
- cov-build --dir "$RESULTS_DIR" $COVERITY_SCAN_BUILD_OPTIONS make -j"$NPROC" V=1
- ;;
-linux-rseq)
- make defconfig
- make -j"$NPROC" prepare
- cov-build --dir "$RESULTS_DIR" $COVERITY_SCAN_BUILD_OPTIONS make -j"$NPROC" kernel/rseq.o kernel/cpu_opv.o V=1 KCPPFLAGS="$CPPFLAGS"
+ cov-build --dir "$RESULTS_DIR" ${COVERITY_SCAN_BUILD_OPTIONS[@]} make -j"$NPROC" V=1
;;
*)
echo "Unsupported build type: $BUILD_TYPE"
# Upload results
echo -e "\033[33;1mUploading Coverity Scan Analysis results...\033[0m"
set +x
-response=$(curl --insecure \
+response=$(curl \
--silent --write-out "\n%{http_code}\n" \
--form project="$COVERITY_SCAN_PROJECT_NAME" \
--form token="$COVERITY_SCAN_TOKEN" \