jjb: babeltrace cleanups

[lttng-ci.git] / scripts / babeltrace / pylint.sh

diff --git a/scripts/babeltrace/pylint.sh b/scripts/babeltrace/pylint.sh
old mode 100644 (file)
new mode 100755 (executable)
index 0971938..dc3950c
--- a/scripts/babeltrace/pylint.sh
+++ b/scripts/babeltrace/pylint.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/sh -exu
 #
 # Copyright (C) 2015 - Michael Jeanson <mjeanson@efficios.com>
 #
@@ -15,22 +15,30 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-BABELTRACE_DIR="dependencies/babeltrace/build"
-BINDINGS_DIR="$BABELTRACE_DIR/lib/python3.4/dist-packages/babeltrace"
+BABELTRACE_DIR="deps/babeltrace/build"
+
+PYTHON3=python3
+P3_VERSION=$($PYTHON3 -c "import sys;print(sys.version[:3])")
+
+BINDINGS_DIR="$BABELTRACE_DIR/lib/python${P3_VERSION}/dist-packages/babeltrace"
 
 PYENV_HOME="$WORKSPACE/.pyenv/"
 
 # Delete previously built virtualenv
-if [ -d $PYENV_HOME ]; then
-    rm -rf $PYENV_HOME
+if [ -d "$PYENV_HOME" ]; then
+    rm -rf "$PYENV_HOME"
 fi
 
 # Create virtualenv and install necessary packages
-virtualenv --system-site-packages -p python3 $PYENV_HOME
-. $PYENV_HOME/bin/activate
+virtualenv --system-site-packages -p ${PYTHON3} "$PYENV_HOME"
+
+set +u
+. "$PYENV_HOME/bin/activate"
+set -u
+
 pip install --quiet pylint
 pip install --quiet pep8
 
-pep8 --exclude="nativebt.py" $BINDINGS_DIR | tee pep8.out
+pep8 --exclude="nativebt.py" "$BINDINGS_DIR" | tee pep8.out
 
-pylint -f parseable --ignore="nativebt.py" $BINDINGS_DIR | tee pylint.out
+pylint -f parseable --ignore="nativebt.py" "$BINDINGS_DIR" | tee pylint.out