#include <dirent.h>
#include <linux/errno.h>
+// For realpath
+#include <limits.h>
+#include <stdlib.h>
+
+
#include "parser.h"
#include <ltt/ltt.h>
#include "ltt-private.h"
*When a trace is closed, all the associated facilities, types and fields
*are released as well.
*
- * MD : If pathname is already absolute, we do not add current working
- * directory to it.
+ * MD : Fixed this function so it uses realpath, dealing well with
+ * forgotten cases (.. were not used correctly before).
*
****************************************************************************/
size_t size = DIR_NAME_SIZE;
abs_pathname[0] = '\0';
- if(pathname[0] == '/')
- {
- strcat(abs_pathname, pathname);
- return;
- }
-
- if(!getcwd(abs_pathname, size)){
- g_warning("Can not get current working directory\n");
- strcat(abs_pathname, pathname);
+ if ( realpath (pathname, abs_pathname) != NULL)
+ return;
+ else
+ {
+ // FIXME : Path is wrong, is it ok to return the pathname unmodified ?
+ strcpy(abs_pathname, pathname);
return;
}
- strcat(abs_pathname,"/");
+ return;
- ptr = (char*)pathname;
- ptr1 = ptr + 1;
- while(*ptr == '.' && *ptr1 == '.'){
- ptr += 3;
- ptr1 = ptr + 1;
- }
- strcat(abs_pathname,ptr);
}
LttTrace *ltt_trace_open(const char *pathname)
gboolean has_slash = FALSE;
get_absolute_pathname(pathname, abs_path);
-
//establish the pathname to different directories
if(abs_path[strlen(abs_path)-1] == '/')has_slash = TRUE;
strcpy(eventdefs,abs_path);
lttEvent->time_delta = *(guint32 *)(t->cur_event_pos + EVENT_ID_SIZE);
lttEvent->event_time = t->current_event_time;
+ lttEvent->event_cycle_count = t->cur_cycle_count;
lttEvent->tracefile = t;
lttEvent->data = t->cur_event_pos + EVENT_HEADER_SIZE;
err = skipEvent(t);
if(err == ERANGE) g_error("event id is out of range\n");
- lttEvent->event_cycle_count = t->cur_cycle_count;
-
return lttEvent;
}
LttTime time;
LttCycleCount cycle_count; // cycle count for the current event
LttCycleCount lEventTotalCycle; // Total cycles from start for event
- double lEventNSec; // Total usecs from start for event
+ LttCycleCount lEventNSec; // Total usecs from start for event
LttTime lTimeOffset; // Time offset in struct LttTime
guint16 evId;
- gint64 nanoSec, tmpCycleCount = (((guint64)1)<<32);
+ LttCycleCount tmpCycleCount = (((LttCycleCount)1)<<32);
evId = *(guint16 *)tf->cur_event_pos;
if(evId == TRACE_BLOCK_START){
lEventTotalCycle -= tf->a_block_start->cycle_count;
// Convert it to nsecs
- lEventNSec = lEventTotalCycle / tf->cycle_per_nsec;
- nanoSec = lEventNSec;
+ lEventNSec = (double)lEventTotalCycle / (double)tf->cycle_per_nsec;
// Determine offset in struct LttTime
- lTimeOffset.tv_nsec = nanoSec % NANOSECONDS_PER_SECOND;
- lTimeOffset.tv_sec = nanoSec / NANOSECONDS_PER_SECOND;
+ lTimeOffset.tv_nsec = lEventNSec % NANOSECONDS_PER_SECOND;
+ lTimeOffset.tv_sec = lEventNSec / NANOSECONDS_PER_SECOND;
time = ltt_time_add(tf->a_block_start->time, lTimeOffset);