-/*
- * Marker support code.
+/* This file is part of the Linux Trace Toolkit viewer
+ * Copyright (C) 2007 Mathieu Desnoyers
+ *
+ * Complete rewrite from the original version made by XangXiu Yang.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License Version 2.1 as published by the Free Software Foundation.
*
- * Mathieu Desnoyers, August 2007
- * License: LGPL.
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the
+ * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+ * Boston, MA 02111-1307, USA.
*/
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
+
#include <glib.h>
#include <stdio.h>
#include <string.h>
*trace_type = LTT_TYPE_STRING;
goto parse_end;
case 'p':
- *trace_type = LTT_TYPE_UNSIGNED_INT;
+ *trace_type = LTT_TYPE_POINTER;
*trace_size = info->pointer_size;
goto parse_end;
case 'd':
*c_type = LTT_TYPE_STRING;
goto parse_end;
case 'p':
- *c_type = LTT_TYPE_UNSIGNED_INT;
+ *c_type = LTT_TYPE_POINTER;
*c_size = info->pointer_size;
goto parse_end;
case 'd':
switch (trace_type) {
case LTT_TYPE_SIGNED_INT:
case LTT_TYPE_UNSIGNED_INT:
+ case LTT_TYPE_POINTER:
field->size = trace_size;
field->alignment = trace_size;
field->attributes = attributes;
unsigned int i;
long offset = 0;
- for (i = 0; i < info->fields->len; i++) {
+ /* Find the last field with a static offset, then update from there. */
+ for (i = info->fields->len - 1; i >= 0; i--) {
field = &g_array_index(info->fields, struct marker_field, i);
+ if (field->static_offset) {
+ offset = field->offset;
+ break;
+ }
+ }
- if (field->static_offset)
- continue;
+ for (; i < info->fields->len; i++) {
+ field = &g_array_index(info->fields, struct marker_field, i);
switch (field->type) {
case LTT_TYPE_SIGNED_INT:
case LTT_TYPE_UNSIGNED_INT:
+ case LTT_TYPE_POINTER:
field->offset = offset + ltt_align(offset, field->alignment,
info->alignment);
offset = field->offset + field->size;
char *name = NULL;
unsigned int field_count = 1;
+ name_begin = fmt;
for (; *fmt ; ++fmt) {
switch (*fmt) {
case '#':
}
break;
case ' ':
- if (!name_end) {
+ if (!name_end && name_begin) {
name_end = fmt;
if (name)
g_free(name);
}
break; /* Skip white spaces */
default:
- if (!name) {
+ if (!name_begin) {
name_begin = fmt;
name_end = NULL;
}
info->fields = g_array_sized_new(FALSE, TRUE,
sizeof(struct marker_field), DEFAULT_FIELDS_NUM);
format_parse(format, info);
+ return 0;
}
int marker_format_event(LttTrace *trace, GQuark name, const char *format)
info = g_hash_table_lookup(trace->markers_hash, (gconstpointer)name);
if (!info)
- g_error("Got marker format %s, but marker name %s has no ID yet. "
+ g_error("Got marker format \"%s\", but marker name \"%s\" has no ID yet. "
"Kernel issue.",
format, name);
for (; info != NULL; info = info->next) {
info->format = g_new(char, strlen(format)+1);
strcpy(info->format, format);
if (marker_parse_format(format, info))
- g_error("Error parsing marker format %s for marker %s", format,
+ g_error("Error parsing marker format \"%s\" for marker \"%s\"", format,
g_quark_to_string(name));
}
+ return 0;
}
int marker_id_event(LttTrace *trace, GQuark name, guint16 id,
uint8_t size_t_size, uint8_t alignment)
{
struct marker_info *info, *head;
+ int found = 0;
- if (trace->markers->len < id)
+ if (trace->markers->len <= id)
trace->markers = g_array_set_size(trace->markers, id+1);
info = &g_array_index(trace->markers, struct marker_info, id);
info->name = name;
if (!head)
g_hash_table_insert(trace->markers_hash, (gpointer)name, info);
else {
- g_hash_table_replace(trace->markers_hash, (gpointer)name, info);
- info->next = head;
+ struct marker_info *iter;
+ for (iter = head; iter != NULL; iter = iter->next)
+ if (iter->name == name)
+ found = 1;
+ if (!found) {
+ g_hash_table_replace(trace->markers_hash, (gpointer)name, info);
+ info->next = head;
+ }
}
+ return 0;
}
int allocate_marker_data(LttTrace *trace)