roadmap update
[lttv.git] / genevent-new / genevent.c
index 7a951bbf1f4fad1b9fcb3a5f0867c11ecc575ec0..9113a11ceec1d968ed2941ad667be46d86a60e8b 100644 (file)
@@ -411,7 +411,8 @@ int print_type_declaration(type_descriptor_t * td, FILE *fd, unsigned int tabs,
                        fprintf(fd, " {\n");
                        for(unsigned int i=0;i<td->labels.position;i++){
                                print_tabs(1, fd);
-                               fprintf(fd, "LTTNG_%s", ((char*)(td->labels.array[i])));
+                               fprintf(fd, "LTTNG_%s = %d", ((char*)td->labels.array[i]),
+            (*(int*)td->labels_values.array[i]));
                                fprintf(fd, ",\n");
                        }
                        fprintf(fd, "};\n");
@@ -574,6 +575,27 @@ int print_type_alignment(type_descriptor_t * td, FILE *fd, unsigned int tabs,
                        case STRING:
                                fprintf(fd, "sizeof(char)");
                                break;
+                       case INT_FIXED:
+                       case UINT_FIXED:
+                       case CHAR:
+                       case UCHAR:
+                       case SHORT:
+                       case USHORT:
+                       case INT:
+                       case UINT:
+                       case FLOAT:
+                       case POINTER:
+                       case LONG:
+                       case ULONG:
+                       case SIZE_T:
+                       case SSIZE_T:
+                       case OFF_T:
+                       case ENUM:
+                               fprintf(fd, "sizeof(");
+                               if(print_type(td, fd, 0, basename, "")) return 1;
+                               fprintf(fd, ")");
+                               break;
+
                        default:
                                printf("error : type unexpected\n");
                                return 1;
@@ -686,14 +708,28 @@ int print_type_write(type_descriptor_t * td, FILE *fd, unsigned int tabs,
                case OFF_T:
                case ENUM:
                        print_tabs(tabs, fd);
-                       fprintf(fd, "size = ");
+                       fprintf(fd, "align = ");
+                       if(print_type_alignment(td, fd, 0, basename, "", "obj")) return 1;
+                       fprintf(fd, ";\n");
+                       fprintf(fd, "\n");
+                       print_tabs(tabs, fd);
+                       fprintf(fd, "if(*len == 0) {\n");
+                       print_tabs(tabs+1, fd);
+                       fprintf(fd, "*to += ltt_align(*to, align); /* align output */\n");
+                       print_tabs(tabs, fd);
+                       fprintf(fd, "} else {\n");
+                       print_tabs(tabs+1, fd);
+                       fprintf(fd, "*len += ltt_align(*to+*len, align); /* alignment, ok to do a memcpy of it */\n");
+                       print_tabs(tabs, fd);
+                       fprintf(fd, "}\n");
+                       fprintf(fd, "\n");
+
+                       print_tabs(tabs, fd);
+                       fprintf(fd, "*len += ");
                        fprintf(fd, "sizeof(");
                        if(print_type(td, fd, 0, basename, "")) return 1;
                        fprintf(fd, ");\n");
-                       print_tabs(tabs, fd);
-                       fprintf(fd, "size += ltt_align(*to+*len, size) + size;\n");
-                       print_tabs(tabs, fd);
-                       fprintf(fd, "*len += size;");
+
                        break;
                case STRING:
                        print_tabs(tabs, fd);
@@ -1032,24 +1068,8 @@ int print_type_write_fct(type_descriptor_t * td, FILE *fd, unsigned int tabs,
 
        fprintf(fd, "{\n");
 
-
-       if(td->fields.position > 0) {
-               int has_type_fixed = 0;
-               for(unsigned int i=0;i<td->fields.position;i++){
-                       /* Search for at least one child with fixed size. It means
-                        * we need local variables.*/
-                       field_t *field = (field_t*)(td->fields.array[i]);
-                       type_descriptor_t *type = field->type;
-                       has_type_fixed = has_type_local(type);
-                       if(has_type_fixed) break;
-               }
-               
-               if(has_type_fixed) {
-                       print_tabs(1, fd);
-                       fprintf(fd, "size_t size;\n");
-               }
-       }
-
+       print_tabs(1, fd);
+       fprintf(fd, "size_t size;\n");
        print_tabs(1, fd);
        fprintf(fd, "size_t align;\n");
        fprintf(fd, "\n");
@@ -1133,29 +1153,37 @@ int print_type_write_fct(type_descriptor_t * td, FILE *fd, unsigned int tabs,
                                print_tabs(1, fd);
                                fprintf(fd, "if(buffer != NULL)\n");
                                print_tabs(2, fd);
-                               fprintf(fd, "memcpy(buffer+*to_base+*to, &obj->len, size);\n");
+                               fprintf(fd, "memcpy(buffer+*to_base+*to, &obj->len, *len);\n");
                                print_tabs(1, fd);
-                               fprintf(fd, "*to += size;\n");
+                               fprintf(fd, "*to += *len;\n");
+                               print_tabs(1, fd);
+                               fprintf(fd, "*len = 0;\n");
                                fprintf(fd, "\n");
-                               
+
                                /* Write the child : varlen child or not ? */
                                if(has_type_fixed_size(((field_t*)td->fields.array[1])->type)) {
                                        /* Fixed size len child : use a multiplication of its size */
 //                                     print_tabs(1, fd);
 //                                     fprintf(fd, "size = sizeof(\n");
+
+                                       //print_tabs(1, fd);
+                                       /* We know that *len does not contain alignment because of the
+                                        * previous align output. len is always 0 here. */
                                        if(print_type_write(((field_t*)td->fields.array[1])->type,
-                                                       fd, 1, basename, "array[0]", "obj->", 1)) return 1;
+                                                       fd, 1, basename, "array[0]", "obj->", 1))
+                                               return 1;
 //                                     fprintf(fd, ");\n");
-//                                     print_tabs(1, fd);
-                                       fprintf(fd, "*to += ltt_align(*to, size);\n");
+                                       fprintf(fd, "\n");
                                        print_tabs(1, fd);
-                                       fprintf(fd, "size = obj->len * size;\n");
+                                       fprintf(fd, "*len = obj->len * (*len);\n");
                                        print_tabs(1, fd);
                                        fprintf(fd, "if(buffer != NULL)\n");
                                        print_tabs(2, fd);
-                                       fprintf(fd, "memcpy(buffer+*to_base+*to, obj->array, size);\n");
+                                       fprintf(fd, "memcpy(buffer+*to_base+*to, obj->array, *len);\n");
+                                       print_tabs(1, fd);
+                                       fprintf(fd, "*to += *len;\n");
                                        print_tabs(1, fd);
-                                       fprintf(fd, "*to += size;\n");
+                                       fprintf(fd, "*len = 0;\n");
                                        fprintf(fd, "\n");
                                } else {
                                        print_tabs(1, fd);
@@ -1171,7 +1199,7 @@ int print_type_write_fct(type_descriptor_t * td, FILE *fd, unsigned int tabs,
                                print_tabs(1, fd);
                                fprintf(fd, "/* Realign the *to_base on arch size, set *to to 0 */\n");
                                print_tabs(1, fd);
-                               fprintf(fd, "*to = ltt_align(*to, sizeof(void *));\n");
+                               fprintf(fd, "*to += ltt_align(*to, sizeof(void *));\n");
                                print_tabs(1, fd);
                                fprintf(fd, "*to_base = *to_base+*to;\n");
                                print_tabs(1, fd);
@@ -1195,7 +1223,7 @@ int print_type_write_fct(type_descriptor_t * td, FILE *fd, unsigned int tabs,
                                print_tabs(1, fd);
                                fprintf(fd, "/* Realign the *to_base on arch size, set *to to 0 */\n");
                                print_tabs(1, fd);
-                               fprintf(fd, "*to = ltt_align(*to, sizeof(void *));\n");
+                               fprintf(fd, "*to += ltt_align(*to, sizeof(void *));\n");
                                print_tabs(1, fd);
                                fprintf(fd, "*to_base = *to_base+*to;\n");
                                print_tabs(1, fd);
@@ -1341,7 +1369,7 @@ int print_event_logging_function(char *basename, facility_t *fac,
                }
                
                if(has_type_fixed) {
-                       fprintf(fd, "size_t size;\n");
+                       fprintf(fd, "size_t align;\n");
                        print_tabs(1, fd);
                }
 
@@ -1398,9 +1426,6 @@ int print_event_logging_function(char *basename, facility_t *fac,
        }
        print_tabs(1, fd);
        fprintf(fd, "reserve_size = *to_base + *to + *len;\n");
-       print_tabs(1, fd);
-       fprintf(fd, "*to_base = *to = *len = 0;\n");
-       fprintf(fd, "\n");
 
        /* Take locks : make sure the trace does not vanish while we write on
         * it. A simple preemption disabling is enough (using rcu traces). */
@@ -1455,7 +1480,14 @@ int print_event_logging_function(char *basename, facility_t *fac,
        fprintf(fd, "&before_hdr_pad, &after_hdr_pad, &header_size);\n");
        /* If error, return */
        print_tabs(2, fd);
-       fprintf(fd, "if(!buffer) return;\n\n");
+       fprintf(fd, "if(!buffer) continue; /* buffer full */\n\n");
+       //print_tabs(2, fd);
+       // for DEBUG only 
+       // fprintf(fd, "goto commit; /* DEBUG : never actually write. */\n\n");
+       print_tabs(2, fd);
+       fprintf(fd, "*to_base = *to = *len = 0;\n");
+       fprintf(fd, "\n");
+
        /* Write event header */
        print_tabs(2, fd);
        fprintf(fd, "ltt_write_event_header(trace, channel, buffer,\n");
@@ -1466,13 +1498,14 @@ int print_event_logging_function(char *basename, facility_t *fac,
        fprintf(fd, "reserve_size, before_hdr_pad, tsc);\n");
        print_tabs(2, fd);
        fprintf(fd, "*to_base += before_hdr_pad + after_hdr_pad + header_size;\n");
+       fprintf(fd, "\n");
        
-       /* write data : assume stack alignment is the same as struct alignment. */
+       /* write data. */
 
        for(unsigned int i=0;i<event->fields.position;i++){
                field_t *field = (field_t*)(event->fields.array[i]);
                type_descriptor_t *type = field->type;
-
+       
                /* Set from */
                print_tabs(2, fd);
                switch(type->type) {
@@ -1497,7 +1530,7 @@ int print_event_logging_function(char *basename, facility_t *fac,
                print_tabs(2, fd);
                fprintf(fd, "/* Flush pending memcpy */\n");
                print_tabs(2, fd);
-               fprintf(fd, "if(len != 0) {\n");
+               fprintf(fd, "if(*len != 0) {\n");
                print_tabs(3, fd);
                fprintf(fd, "memcpy(buffer+*to_base+*to, *from, *len);\n");
                print_tabs(3, fd);
@@ -1513,6 +1546,8 @@ int print_event_logging_function(char *basename, facility_t *fac,
 
        
        /* commit */
+       // for DEBUG only.
+       //fprintf(fd, "commit:\n"); /* DEBUG! */
        print_tabs(2, fd);
        fprintf(fd, "ltt_commit_slot(relayfs_buf, buffer, slot_size);\n\n");
        
This page took 0.02658 seconds and 4 git commands to generate.