projects
/
lttng-modules.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fix module get/put handling wrt data free (use after free)
[lttng-modules.git]
/
probes
/
lttng-ftrace.c
diff --git
a/probes/lttng-ftrace.c
b/probes/lttng-ftrace.c
index 7c4fc9f55d78f5fc98898cd45af8a630b37e90ae..ec086902892d644fcee8c57f70d78231cc4944f2 100644
(file)
--- a/
probes/lttng-ftrace.c
+++ b/
probes/lttng-ftrace.c
@@
-92,6
+92,7
@@
int lttng_create_ftrace_event(const char *name, struct ltt_event *event)
fields[1].type.u.basic.integer.base = 16;
fields[1].type.u.basic.integer.encoding = lttng_encode_none;
fields[1].type.u.basic.integer.base = 16;
fields[1].type.u.basic.integer.encoding = lttng_encode_none;
+ desc->owner = THIS_MODULE;
event->desc = desc;
return 0;
event->desc = desc;
return 0;
@@
-118,7
+119,7
@@
int lttng_ftrace_register(const char *name,
if (ret)
goto error;
if (ret)
goto error;
- event->u.ftrace.symbol_name = kstrdup(name, GFP_KERNEL);
+ event->u.ftrace.symbol_name = kstrdup(
symbol_
name, GFP_KERNEL);
if (!event->u.ftrace.symbol_name)
goto name_error;
if (!event->u.ftrace.symbol_name)
goto name_error;
@@
-127,7
+128,7
@@
int lttng_ftrace_register(const char *name,
ret = wrapper_register_ftrace_function_probe(event->u.ftrace.symbol_name,
<tng_ftrace_ops, event);
ret = wrapper_register_ftrace_function_probe(event->u.ftrace.symbol_name,
<tng_ftrace_ops, event);
- if (ret)
+ if (ret
< 0
)
goto register_error;
return 0;
goto register_error;
return 0;
@@
-145,14
+146,18
@@
void lttng_ftrace_unregister(struct ltt_event *event)
{
wrapper_unregister_ftrace_function_probe(event->u.ftrace.symbol_name,
<tng_ftrace_ops, event);
{
wrapper_unregister_ftrace_function_probe(event->u.ftrace.symbol_name,
<tng_ftrace_ops, event);
+}
+EXPORT_SYMBOL_GPL(lttng_ftrace_unregister);
+
+void lttng_ftrace_destroy_private(struct ltt_event *event)
+{
kfree(event->u.ftrace.symbol_name);
kfree(event->desc->fields);
kfree(event->desc->name);
kfree(event->desc);
}
kfree(event->u.ftrace.symbol_name);
kfree(event->desc->fields);
kfree(event->desc->name);
kfree(event->desc);
}
-EXPORT_SYMBOL_GPL(lttng_ftrace_
unregister
);
+EXPORT_SYMBOL_GPL(lttng_ftrace_
destroy_private
);
-/* This module is permanent. */
int lttng_ftrace_init(void)
{
wrapper_vmalloc_sync_all();
int lttng_ftrace_init(void)
{
wrapper_vmalloc_sync_all();
@@
-160,6
+165,15
@@
int lttng_ftrace_init(void)
}
module_init(lttng_ftrace_init)
}
module_init(lttng_ftrace_init)
+/*
+ * Ftrace takes care of waiting for a grace period (RCU sched) at probe
+ * unregistration, and disables preemption around probe call.
+ */
+void lttng_ftrace_exit(void)
+{
+}
+module_exit(lttng_ftrace_exit)
+
MODULE_LICENSE("GPL and additional rights");
MODULE_AUTHOR("Mathieu Desnoyers");
MODULE_DESCRIPTION("Linux Trace Toolkit Ftrace Support");
MODULE_LICENSE("GPL and additional rights");
MODULE_AUTHOR("Mathieu Desnoyers");
MODULE_DESCRIPTION("Linux Trace Toolkit Ftrace Support");
This page took
0.025219 seconds
and
4
git commands to generate.