1 /* This file is part of the Linux Trace Toolkit viewer
2 * Copyright (C) 2003-2004 XangXiu Yang
4 * This program is free software; you can redistribute it and/or modify
5 * it under the terms of the GNU General Public License Version 2 as
6 * published by the Free Software Foundation;
8 * This program is distributed in the hope that it will be useful,
9 * but WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 * GNU General Public License for more details.
13 * You should have received a copy of the GNU General Public License
14 * along with this program; if not, write to the Free Software
15 * Foundation, Inc., 59 Temple Place - Suite 330, Boston,
29 #include <ltt/event.h>
31 #include <ltt/trace.h>
33 #include <lttv/lttv.h>
34 #include <lttv/module.h>
35 #include <lttv/tracecontext.h>
36 #include <lttv/hook.h>
37 #include <lttv/state.h>
38 #include <lttv/stats.h>
40 #include <lttvwindow/lttvwindow.h>
41 #include <lttvwindow/lttvwindowtraces.h>
43 #include "hGuiStatisticInsert.xpm"
45 #define PATH_LENGTH 256 /* CHECK */
46 #define MAX_NUMBER_EVENT "max_number_event"
49 //static GPtrArray * statistic_traceset;
51 /** Array containing instanced objects. Used when module is unloaded */
52 static GSList
*g_statistic_viewer_data_list
= NULL
;
54 typedef struct _StatisticViewerData StatisticViewerData
;
56 static void request_background_data(StatisticViewerData
*svd
);
57 GtkWidget
*guistatistic_get_widget(StatisticViewerData
*svd
);
59 //! Statistic Viewer's constructor hook
60 GtkWidget
*h_gui_statistic(Tab
*tab
);
61 //! Statistic Viewer's constructor
62 StatisticViewerData
*gui_statistic(Tab
*tab
);
63 //! Statistic Viewer's destructor
64 void gui_statistic_destructor(StatisticViewerData
*statistic_viewer_data
);
66 static void tree_selection_changed_cb (GtkTreeSelection
*selection
, gpointer data
);
68 void statistic_destroy_hash_key(gpointer key
);
69 void statistic_destroy_hash_data(gpointer data
);
71 void show_traceset_stats(StatisticViewerData
* statistic_viewer_data
);
72 void show_tree(StatisticViewerData
* statistic_viewer_data
,
73 LttvAttribute
* stats
, GtkTreeIter
* parent
);
74 void show_statistic(StatisticViewerData
* statistic_viewer_data
,
75 LttvAttribute
* stats
, GtkTextBuffer
* buf
);
78 gboolean
statistic_traceset_changed(void * hook_data
, void * call_data
);
79 //void statistic_add_context_hooks(StatisticViewerData * statistic_viewer_data,
80 // LttvTracesetContext * tsc);
81 //void statistic_remove_context_hooks(StatisticViewerData *statistic_viewer_data,
82 // LttvTracesetContext * tsc);
84 //gboolean statistic_insert_traceset_stats(void * stats);
92 struct _StatisticViewerData
{
94 //LttvTracesetStats * stats;
97 //gboolean shown; //indicate if the statistic is shown or not
100 GtkWidget
* hpaned_v
;
101 GtkTreeStore
* store_m
;
104 //scroll window containing Tree View
105 GtkWidget
* scroll_win_tree
;
108 //scroll window containing Text View
109 GtkWidget
* scroll_win_text
;
112 GtkTreeSelection
*select_c
;
115 GHashTable
*statistic_hash
;
121 /* Action to do when background computation completed.
123 * Eventually, will have to check that every requested traces are finished
124 * before doing the redraw. It will save unnecessary processor usage.
127 static gint
background_ready(void *hook_data
, void *call_data
)
129 StatisticViewerData
*svd
= (StatisticViewerData
*)hook_data
;
131 LttvTrace
*trace
= (LttvTrace
*)call_data
;
133 g_debug("statistics viewer : background computation data ready.");
135 gtk_tree_store_clear (svd
->store_m
);
137 lttv_stats_sum_traceset(lttvwindow_get_traceset_stats(tab
));
138 show_traceset_stats(svd
);
143 /* Request background computation. Verify if it is in progress or ready first.
145 * Right now, for all loaded traces.
147 * Later : must be only for each trace in the tab's traceset.
149 static void request_background_data(StatisticViewerData
*svd
)
151 gint num_traces
= lttvwindowtraces_get_number();
155 LttvHooks
*background_ready_hook
=
157 lttv_hooks_add(background_ready_hook
, background_ready
, svd
,
160 for(i
=0;i
<num_traces
;i
++) {
161 trace
= lttvwindowtraces_get_trace(i
);
163 if(lttvwindowtraces_get_ready(g_quark_from_string("stats"),trace
)==FALSE
) {
165 if(lttvwindowtraces_get_in_progress(g_quark_from_string("stats"),
167 /* We first remove requests that could have been done for the same
168 * information. Happens when two viewers ask for it before servicing
171 if(!lttvwindowtraces_background_request_find(trace
, "stats"))
172 lttvwindowtraces_background_request_queue(
173 main_window_get_widget(svd
->tab
), trace
, "stats");
174 lttvwindowtraces_background_notify_queue(svd
,
178 background_ready_hook
);
179 } else { /* in progress */
181 lttvwindowtraces_background_notify_current(svd
,
185 background_ready_hook
);
190 lttv_hooks_call(background_ready_hook
, NULL
);
193 lttv_hooks_destroy(background_ready_hook
);
197 GtkWidget
*guistatistic_get_widget(StatisticViewerData
*svd
)
199 return svd
->hpaned_v
;
204 gui_statistic_destructor(StatisticViewerData
*statistic_viewer_data
)
206 Tab
*tab
= statistic_viewer_data
->tab
;
208 /* May already been done by GTK window closing */
209 if(GTK_IS_WIDGET(guistatistic_get_widget(statistic_viewer_data
))){
210 g_info("widget still exists");
213 lttvwindow_unregister_traceset_notify(statistic_viewer_data
->tab
,
214 statistic_traceset_changed
,
215 statistic_viewer_data
);
217 lttvwindowtraces_background_notify_remove(statistic_viewer_data
);
219 g_hash_table_destroy(statistic_viewer_data
->statistic_hash
);
220 g_statistic_viewer_data_list
=
221 g_slist_remove(g_statistic_viewer_data_list
, statistic_viewer_data
);
222 g_free(statistic_viewer_data
);
227 * Statistic Viewer's constructor hook
229 * This constructor is given as a parameter to the menuitem and toolbar button
230 * registration. It creates the list.
231 * @param parent_window A pointer to the parent window.
232 * @return The widget created.
235 h_gui_statistic(Tab
*tab
)
237 StatisticViewerData
* statistic_viewer_data
= gui_statistic(tab
) ;
239 if(statistic_viewer_data
)
240 return guistatistic_get_widget(statistic_viewer_data
);
246 gboolean
statistic_insert_traceset_stats(void * stats
)
251 len
= statistic_traceset
->len
;
253 s
= g_ptr_array_index(statistic_traceset
, i
);
254 if(s
== stats
) break;
257 g_ptr_array_add(statistic_traceset
, stats
);
265 * Statistic Viewer's constructor
267 * This constructor is used to create StatisticViewerData data structure.
268 * @return The Statistic viewer data created.
270 StatisticViewerData
*
271 gui_statistic(Tab
*tab
)
273 GtkCellRenderer
*renderer
;
274 GtkTreeViewColumn
*column
;
276 StatisticViewerData
* statistic_viewer_data
= g_new(StatisticViewerData
,1);
278 statistic_viewer_data
->tab
= tab
;
279 // statistic_viewer_data->stats =
280 // lttvwindow_get_traceset_stats(statistic_viewer_data->tab);
281 // statistic_viewer_data->calculate_stats =
282 // statistic_insert_traceset_stats((void *)statistic_viewer_data->stats);
284 lttvwindow_register_traceset_notify(statistic_viewer_data
->tab
,
285 statistic_traceset_changed
,
286 statistic_viewer_data
);
288 statistic_viewer_data
->statistic_hash
= g_hash_table_new_full(g_str_hash
,
290 statistic_destroy_hash_key
,
293 statistic_viewer_data
->hpaned_v
= gtk_hpaned_new();
294 statistic_viewer_data
->store_m
= gtk_tree_store_new (N_COLUMNS
, G_TYPE_STRING
);
295 statistic_viewer_data
->tree_v
=
296 gtk_tree_view_new_with_model (
297 GTK_TREE_MODEL (statistic_viewer_data
->store_m
));
298 g_object_unref (G_OBJECT (statistic_viewer_data
->store_m
));
300 // Setup the selection handler
301 statistic_viewer_data
->select_c
= gtk_tree_view_get_selection (GTK_TREE_VIEW (statistic_viewer_data
->tree_v
));
302 gtk_tree_selection_set_mode (statistic_viewer_data
->select_c
, GTK_SELECTION_SINGLE
);
303 g_signal_connect (G_OBJECT (statistic_viewer_data
->select_c
), "changed",
304 G_CALLBACK (tree_selection_changed_cb
),
305 statistic_viewer_data
);
307 renderer
= gtk_cell_renderer_text_new ();
308 column
= gtk_tree_view_column_new_with_attributes ("Statistic Name",
312 gtk_tree_view_column_set_alignment (column
, 0.0);
313 // gtk_tree_view_column_set_fixed_width (column, 45);
314 gtk_tree_view_append_column (GTK_TREE_VIEW (statistic_viewer_data
->tree_v
), column
);
317 gtk_tree_view_set_headers_visible(GTK_TREE_VIEW (statistic_viewer_data
->tree_v
), FALSE
);
319 statistic_viewer_data
->scroll_win_tree
= gtk_scrolled_window_new (NULL
, NULL
);
320 gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(statistic_viewer_data
->scroll_win_tree
),
321 GTK_POLICY_AUTOMATIC
,GTK_POLICY_AUTOMATIC
);
323 gtk_container_add (GTK_CONTAINER (statistic_viewer_data
->scroll_win_tree
), statistic_viewer_data
->tree_v
);
324 gtk_paned_pack1(GTK_PANED(statistic_viewer_data
->hpaned_v
),statistic_viewer_data
->scroll_win_tree
, TRUE
, FALSE
);
325 gtk_paned_set_position(GTK_PANED(statistic_viewer_data
->hpaned_v
), 160);
327 statistic_viewer_data
->scroll_win_text
= gtk_scrolled_window_new (NULL
, NULL
);
328 gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(statistic_viewer_data
->scroll_win_text
),
329 GTK_POLICY_AUTOMATIC
,GTK_POLICY_AUTOMATIC
);
331 statistic_viewer_data
->text_v
= gtk_text_view_new ();
333 gtk_text_view_set_editable(GTK_TEXT_VIEW(statistic_viewer_data
->text_v
),FALSE
);
334 gtk_text_view_set_cursor_visible(GTK_TEXT_VIEW(statistic_viewer_data
->text_v
),FALSE
);
335 gtk_container_add (GTK_CONTAINER (statistic_viewer_data
->scroll_win_text
), statistic_viewer_data
->text_v
);
336 gtk_paned_pack2(GTK_PANED(statistic_viewer_data
->hpaned_v
), statistic_viewer_data
->scroll_win_text
, TRUE
, FALSE
);
338 gtk_container_set_border_width(
339 GTK_CONTAINER(statistic_viewer_data
->hpaned_v
), 1);
341 gtk_widget_show(statistic_viewer_data
->scroll_win_tree
);
342 gtk_widget_show(statistic_viewer_data
->scroll_win_text
);
343 gtk_widget_show(statistic_viewer_data
->tree_v
);
344 gtk_widget_show(statistic_viewer_data
->text_v
);
345 gtk_widget_show(statistic_viewer_data
->hpaned_v
);
347 g_object_set_data_full(
348 G_OBJECT(guistatistic_get_widget(statistic_viewer_data
)),
349 "statistic_viewer_data",
350 statistic_viewer_data
,
351 (GDestroyNotify
)gui_statistic_destructor
);
353 /* Add the object's information to the module's array */
354 g_statistic_viewer_data_list
= g_slist_append(
355 g_statistic_viewer_data_list
,
356 statistic_viewer_data
);
358 request_background_data(statistic_viewer_data
);
360 return statistic_viewer_data
;
364 tree_selection_changed_cb (GtkTreeSelection
*selection
, gpointer data
)
366 StatisticViewerData
*statistic_viewer_data
= (StatisticViewerData
*)data
;
368 GtkTreeModel
*model
= GTK_TREE_MODEL(statistic_viewer_data
->store_m
);
373 GtkTextIter text_iter
;
374 LttvAttribute
* stats
;
376 if (gtk_tree_selection_get_selected (selection
, &model
, &iter
))
378 gtk_tree_model_get (model
, &iter
, NAME_COLUMN
, &event
, -1);
380 path
= gtk_tree_model_get_path(GTK_TREE_MODEL(model
),&iter
);
381 str
= gtk_tree_path_to_string (path
);
382 stats
= (LttvAttribute
*)g_hash_table_lookup (statistic_viewer_data
->statistic_hash
,str
);
385 buf
= gtk_text_view_get_buffer((GtkTextView
*)statistic_viewer_data
->text_v
);
386 gtk_text_buffer_set_text(buf
,"Statistic for '", -1);
387 gtk_text_buffer_get_end_iter(buf
, &text_iter
);
388 gtk_text_buffer_insert(buf
, &text_iter
, event
, strlen(event
));
389 gtk_text_buffer_get_end_iter(buf
, &text_iter
);
390 gtk_text_buffer_insert(buf
, &text_iter
, "' :\n\n",5);
392 show_statistic(statistic_viewer_data
, stats
, buf
);
398 void statistic_destroy_hash_key(gpointer key
)
410 void show_traceset_stats(StatisticViewerData
* statistic_viewer_data
)
412 Tab
*tab
= statistic_viewer_data
->tab
;
416 LttSystemDescription
*desc
;
417 LttvTracesetStats
* tscs
= lttvwindow_get_traceset_stats(tab
);
418 gchar
* str
, trace_str
[PATH_LENGTH
];
421 GtkTreeStore
* store
= statistic_viewer_data
->store_m
;
423 if(tscs
->stats
== NULL
) return;
425 lttv_attribute_write_xml(tscs
->stats
, stdout
, 1, 4);
428 ts
= tscs
->parent
.parent
.ts
;
429 nb
= lttv_traceset_number(ts
);
432 gtk_tree_store_append (store
, &iter
, NULL
);
433 gtk_tree_store_set (store
, &iter
,
434 NAME_COLUMN
, "Traceset statistics",
436 path
= gtk_tree_model_get_path(GTK_TREE_MODEL(store
), &iter
);
437 str
= gtk_tree_path_to_string (path
);
438 g_hash_table_insert(statistic_viewer_data
->statistic_hash
,
439 (gpointer
)str
, tscs
->stats
);
440 show_tree(statistic_viewer_data
, tscs
->stats
, &iter
);
442 //show stats for all traces
443 for(i
= 0 ; i
< nb
; i
++) {
444 tcs
= (LttvTraceStats
*)(LTTV_TRACESET_CONTEXT(tscs
)->traces
[i
]);
446 desc
= ltt_trace_system_description(tcs
->parent
.parent
.t
);
447 LttTime start_time
= ltt_trace_system_description_trace_start_time(desc
);
448 sprintf(trace_str
, "Trace on system %s at time %lu.%09lu",
449 ltt_trace_system_description_node_name(desc
),
453 sprintf(trace_str
, g_quark_to_string(ltt_trace_name(tcs
->parent
.parent
.t
)));
454 gtk_tree_store_append (store
, &iter
, NULL
);
455 gtk_tree_store_set (store
, &iter
,NAME_COLUMN
,trace_str
,-1);
456 path
= gtk_tree_model_get_path(GTK_TREE_MODEL(store
), &iter
);
457 str
= gtk_tree_path_to_string (path
);
458 g_hash_table_insert(statistic_viewer_data
->statistic_hash
,
459 (gpointer
)str
,tcs
->stats
);
460 show_tree(statistic_viewer_data
, tcs
->stats
, &iter
);
462 lttv_attribute_write_xml(tcs
->stats
, stdout
, 3, 4);
467 void show_tree(StatisticViewerData
* statistic_viewer_data
,
468 LttvAttribute
* stats
, GtkTreeIter
* parent
)
471 LttvAttribute
*subtree
;
472 LttvAttributeName name
;
473 LttvAttributeValue value
;
474 LttvAttributeType type
;
476 gchar
* str
, dir_str
[PATH_LENGTH
];
479 GtkTreeStore
* store
= statistic_viewer_data
->store_m
;
481 nb
= lttv_attribute_get_number(stats
);
482 for(i
= 0 ; i
< nb
; i
++) {
483 type
= lttv_attribute_get(stats
, i
, &name
, &value
, &is_named
);
486 if(LTTV_IS_ATTRIBUTE(*(value
.v_gobject
))) {
487 subtree
= (LttvAttribute
*)*(value
.v_gobject
);
489 sprintf(dir_str
, "%s", g_quark_to_string(name
));
491 sprintf(dir_str
, "%lu", name
);
492 gtk_tree_store_append (store
, &iter
, parent
);
493 gtk_tree_store_set (store
, &iter
,NAME_COLUMN
,dir_str
,-1);
494 path
= gtk_tree_model_get_path(GTK_TREE_MODEL(store
), &iter
);
495 str
= gtk_tree_path_to_string (path
);
496 g_hash_table_insert(statistic_viewer_data
->statistic_hash
,
497 (gpointer
)str
, subtree
);
498 show_tree(statistic_viewer_data
, subtree
, &iter
);
507 void show_statistic(StatisticViewerData
* statistic_viewer_data
,
508 LttvAttribute
* stats
, GtkTextBuffer
* buf
)
511 LttvAttributeName name
;
512 LttvAttributeValue value
;
513 LttvAttributeType type
;
515 gchar type_name
[PATH_LENGTH
], type_value
[PATH_LENGTH
];
516 GtkTextIter text_iter
;
519 nb
= lttv_attribute_get_number(stats
);
520 for(i
= 0 ; i
< nb
; i
++) {
521 type
= lttv_attribute_get(stats
, i
, &name
, &value
, &is_named
);
523 sprintf(type_name
,"%s", g_quark_to_string(name
));
525 sprintf(type_name
,"%lu", name
);
526 type_value
[0] = '\0';
529 sprintf(type_value
, " : %d\n", *value
.v_int
);
532 sprintf(type_value
, " : %u\n", *value
.v_uint
);
535 sprintf(type_value
, " : %ld\n", *value
.v_long
);
538 sprintf(type_value
, " : %lu\n", *value
.v_ulong
);
541 sprintf(type_value
, " : %f\n", (double)*value
.v_float
);
544 sprintf(type_value
, " : %f\n", *value
.v_double
);
547 sprintf(type_value
, " : %10lu.%09lu\n", value
.v_time
->tv_sec
,
548 value
.v_time
->tv_nsec
);
551 sprintf(type_value
, " : POINTER\n");
554 sprintf(type_value
, " : %s\n", *value
.v_string
);
559 if(strlen(type_value
)){
561 strcat(type_name
,type_value
);
562 gtk_text_buffer_get_end_iter(buf
, &text_iter
);
563 gtk_text_buffer_insert(buf
, &text_iter
, type_name
, strlen(type_name
));
568 sprintf(type_value
, "No statistic information in this directory.\nCheck in subdirectories please.\n");
569 gtk_text_buffer_get_end_iter(buf
, &text_iter
);
570 gtk_text_buffer_insert(buf
, &text_iter
, type_value
, strlen(type_value
));
575 gboolean
statistic_traceset_changed(void * hook_data
, void * call_data
)
577 StatisticViewerData
*statistic_viewer_data
= (StatisticViewerData
*) hook_data
;
579 request_background_data(statistic_viewer_data
);
585 void statistic_add_context_hooks(StatisticViewerData
* statistic_viewer_data
,
586 LttvTracesetContext
* tsc
)
588 gint i
, j
, nbi
, nb_tracefile
;
590 LttvTraceContext
*tc
;
591 LttvTracefileContext
*tfc
;
592 LttvTracesetSelector
* ts_s
;
593 LttvTraceSelector
* t_s
;
594 LttvTracefileSelector
* tf_s
;
597 ts_s
= (LttvTracesetSelector
*)g_object_get_data(G_OBJECT(statistic_viewer_data
->hpaned_v
),
598 statistic_viewer_data
->filter_key
);
600 //if there are hooks for traceset, add them here
602 nbi
= lttv_traceset_number(tsc
->ts
);
603 for(i
= 0 ; i
< nbi
; i
++) {
604 t_s
= lttv_traceset_selector_trace_get(ts_s
,i
);
605 selected
= lttv_trace_selector_get_selected(t_s
);
606 if(!selected
) continue;
609 //if there are hooks for trace, add them here
611 nb_tracefile
= ltt_trace_control_tracefile_number(trace
) +
612 ltt_trace_per_cpu_tracefile_number(trace
);
614 for(j
= 0 ; j
< nb_tracefile
; j
++) {
615 tf_s
= lttv_trace_selector_tracefile_get(t_s
,j
);
616 selected
= lttv_tracefile_selector_get_selected(tf_s
);
617 if(!selected
) continue;
618 tfc
= tc
->tracefiles
[j
];
620 //if there are hooks for tracefile, add them here
621 // lttv_tracefile_context_add_hooks(tfc, NULL,NULL,NULL,NULL,
622 // statistic_viewer_data->before_event_hooks,NULL);
626 lttv_stats_add_event_hooks(LTTV_TRACESET_STATS(tsc
));
630 void statistic_remove_context_hooks(StatisticViewerData
* statistic_viewer_data
,
631 LttvTracesetContext
* tsc
)
633 gint i
, j
, nbi
, nb_tracefile
;
635 LttvTraceContext
*tc
;
636 LttvTracefileContext
*tfc
;
637 LttvTracesetSelector
* ts_s
;
638 LttvTraceSelector
* t_s
;
639 LttvTracefileSelector
* tf_s
;
642 ts_s
= (LttvTracesetSelector
*)g_object_get_data(G_OBJECT(statistic_viewer_data
->hpaned_v
),
643 statistic_viewer_data
->filter_key
);
645 //if there are hooks for traceset, remove them here
647 nbi
= lttv_traceset_number(tsc
->ts
);
648 for(i
= 0 ; i
< nbi
; i
++) {
649 t_s
= lttv_traceset_selector_trace_get(ts_s
,i
);
650 selected
= lttv_trace_selector_get_selected(t_s
);
651 if(!selected
) continue;
654 //if there are hooks for trace, remove them here
656 nb_tracefile
= ltt_trace_control_tracefile_number(trace
) +
657 ltt_trace_per_cpu_tracefile_number(trace
);
659 for(j
= 0 ; j
< nb_tracefile
; j
++) {
660 tf_s
= lttv_trace_selector_tracefile_get(t_s
,j
);
661 selected
= lttv_tracefile_selector_get_selected(tf_s
);
662 if(!selected
) continue;
663 tfc
= tc
->tracefiles
[j
];
665 //if there are hooks for tracefile, remove them here
666 // lttv_tracefile_context_remove_hooks(tfc, NULL,NULL,NULL,NULL,
667 // statistic_viewer_data->before_event_hooks,NULL);
671 lttv_stats_remove_event_hooks(LTTV_TRACESET_STATS(tsc
));
676 * plugin's init function
678 * This function initializes the Statistic Viewer functionnality through the
683 lttvwindow_register_constructor("guistatistics",
685 "Insert Statistic Viewer",
686 hGuiStatisticInsert_xpm
,
687 "Insert Statistic Viewer",
691 void statistic_destroy_walk(gpointer data
, gpointer user_data
)
693 StatisticViewerData
*svd
= (StatisticViewerData
*)data
;
695 g_debug("CFV.c : statistic_destroy_walk, %p", svd
);
696 /* May already have been done by GTK window closing */
697 if(GTK_IS_WIDGET(guistatistic_get_widget(svd
)))
698 gtk_widget_destroy(guistatistic_get_widget(svd
));
702 * plugin's destroy function
704 * This function releases the memory reserved by the module and unregisters
705 * everything that has been registered in the gtkTraceSet API.
707 static void destroy() {
709 g_slist_foreach(g_statistic_viewer_data_list
, statistic_destroy_walk
, NULL
);
710 g_slist_free(g_statistic_viewer_data_list
);
712 lttvwindow_unregister_constructor(h_gui_statistic
);
717 LTTV_MODULE("guistatistics", "Statistics viewer", \
718 "Graphical module to view statistics about processes, CPUs and systems", \
719 init
, destroy
, "lttvwindow")